Open Bug 432384 Opened 12 years ago Updated 8 years ago

Unable to set value of label in a popup after appending it - regression

Categories

(Toolkit :: XUL Widgets, defect)

x86
Windows XP
defect
Not set

Tracking

()

People

(Reporter: velcrospud, Unassigned)

References

Details

(Keywords: regression, testcase)

Attachments

(1 file)

2.51 KB, application/vnd.mozilla.xul+xml
Details
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050506 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050506 Minefield/3.0pre

Moving a label into a popup and then trying to change it's value fails with no error.
However, showing the popup before trying to change the label's value will allow it to work

See testcase

This a regression - testcase works in Firefox 2

Impact - This is causing bugs in both the Download Statusbar and Menu Editor extensions - and possibly other extensions with dynamic popups

Reproducible: Always
Attached file testcase
Didn't look into this carefully, but confirming to get on the radar (no obvious dupes and I can reproduce the issue).

Asking for blocking, since this affects extensions and is a regression.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.9?
Keywords: regression, testcase
Version: unspecified → Trunk
Yes, the binding isn't applied because the label has no frame yet until the popup is visible.
Given this is a regression from October, we've had no dups, and comment 4 I don't think this can block.  Please re-nom if disagree..
Flags: blocking1.9? → blocking1.9-
How could this ever have worked? It's always been the case that XBL was only
attached when an element is layed out, or when the wrapper is created, which is
the first time you touch the element from javascript.
(In reply to comment #4)
> Yes, the binding isn't applied because the label has no frame yet until the
> popup is visible.

So, are you saying this is the expected result?  That doesn't seem like a good solution.

----

Also, I didn't mention that the problem is permanent - if you try to set the value (it fails), then you show the popup, then try to set the value again, it still fails
- Once it fails the first time, it is preventing subsequent attempts at setting the value
(In reply to comment #6)
> How could this ever have worked? It's always been the case that XBL was only
> attached when an element is layed out, or when the wrapper is created, which is
> the first time you touch the element from javascript.
> 

Actually I don't really know enough about xbl construction to be able to answer or know for sure. I do know that the bug is caused because the binding isn't applied.

> Also, I didn't mention that the problem is permanent - if you try to set the
> value (it fails), then you show the popup, then try to set the value again, it
> still fails
> - Once it fails the first time, it is preventing subsequent attempts at setting
> the value

Sounds right, as the first attempt will set a field named 'label' which masks the xbl supplied implementation. Or something like that.

You need to log in before you can comment on or make changes to this bug.