Closed Bug 432644 Opened 16 years ago Closed 15 years ago

Some cleanup related to <nsis/common.nsh>

Categories

(Firefox :: Installer, defect)

x86
Windows 2000
defect
Not set
trivial

Tracking

()

RESOLVED WONTFIX

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(2 files, 1 obsolete file)

Follouw-up after bug 429851 Comment 1:
{{
Vlado Valastiak (wladow, Mozilla.sk)   2008-04-19 13:11:10 PDT

Note: Previously used text MUI_INNERTEXT_LICENSE_BOTTOM_RADIOBUTTONS could be
probably removed, but both FX and TB are keeping it, so I didn't remove it to
stay consistent.
}}

See
<http://mxr.mozilla.org/mozilla/search?string=LICENSE_BOTTOM_&case=on&tree=mozilla>
No longer depends on: 429851
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #319816 - Flags: review?(bugzilla)
This bug doesn't block bugs 340173, 397131, 399665, 429851, removing those
dependencies.
No longer blocks: 340173, 397131, 399665, 429851
Tell me if
{{
!ifdef MUI_INNERTEXT_LICENSE_BOTTOM_RADIOBUTTONS
  !insertmacro MUI_LANGUAGEFILE_LANGSTRING_PAGE LICENSE "MUI_INNERTEXT_LICENSE_BOTTOM_RADIOBUTTONS"
!endif
}}
could be removed too, or if it must be kept in case other apps would (still) be using it.
Attachment #319819 - Flags: review?(robert.bugzilla)
Attached patch (Bv1a-FfTbTk) <*/installer/*> (obsolete) — Splinter Review
Attachment #319819 - Attachment is obsolete: true
Attachment #319821 - Flags: review?(robert.bugzilla)
Attachment #319819 - Flags: review?(robert.bugzilla)
Attachment #319819 - Attachment is obsolete: false
Attachment #319819 - Flags: review?(robert.bugzilla)
Comment on attachment 319821 [details] [diff] [review]
(Bv1a-FfTbTk) <*/installer/*>

Aah ... got misleaded by bug 303683 :-<
Attachment #319821 - Attachment is obsolete: true
Attachment #319821 - Flags: review?(robert.bugzilla)
(In reply to comment #2)
> This bug doesn't block bugs 340173, 397131, 399665, 429851, removing those
> dependencies.

"Depends on" then, to keep track of where this came from.
Depends on: 340173, 397131, 399665, 429851
Comment on attachment 319819 [details] [diff] [review]
(Bv1-FfTbTk) <*/installer/*>

There is absolutely no harm in keeping the strings and I want to keep the commented out code which was copied from the original source for my own reference.
Attachment #319819 - Flags: review?(robert.bugzilla) → review-
Component: Installer: XPInstall Engine → NSIS Installer
Product: Core → Toolkit
QA Contact: xpi-engine → nsis.installer
As stated in comment #7 I want to keep the commented out code in common.nsh. If you'd like to remove the strings from the individual app mui.properties files please reopen this bug and move it to the right product (e.g. Suite or Thunderbird) or file new bugs. Resolving -> wontfix
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Comment on attachment 319816 [details] [diff] [review]
(Av1-SM) <mui.properties>

same review then as Rob
Attachment #319816 - Flags: review?(bugzilla) → review-
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: