432736 - Blocklist vietnamese language pack 2.0

Status: RESOLVED FIXED

(Toolkit :: Blocklist Policy Requests, defect)

Description

[Daniel Veditz [:dveditz]]

Due to unwanted virus-droppings in help we should blocklist the Vietnamese Language Pack version 2.0.  Version 2.0.0.9 is OK, but AMO considers it older so people are getting the 2.0 version.

This is AMO number 5954,
em:id="[e-mail]"

Comment 1

[Daniel Veditz [:dveditz]]

and by "we should" I mean "do it ASAP". Basil has signed off on this.

Comment 2

[Reed Loden [:reed]]

Something like this for the SQL?

insert into blitems(guid,min,max)
values('[e-mail]','2.0','2.0');
insert into blapps(blitem_id, guid, min, max) values((select id from blitems
where guid = '[e-mail]'),
'{ec8030f7-c20a-464f-9b0e-13a3a9e97384}', '*', '*');

If I have everything correct, that should blocklist v2.0 of the add-on on all versions of Firefox. Is that what you want?

Comment 3

[Daniel Veditz [:dveditz]]

If possible can we at the same time make the "older" version 2.0.0.9 available for users? At least they'd have something they could go back/up to, and the difference (other than the virus droppings) is only in a couple cookie.dtd strings -- not a big change even if the old text is wrong somehow.

Comment 4

[Justin Scott [:fligtar]]

Attachment: blocklist xml

This is the current blocklist xml with a variation of reed's SQL run. Testing it to make sure it works properly.

If anyone else on VPN wants to test, extensions.blocklist.url = http://fligtar.khan.mozilla.org/addons/trunk/site/blocklist/1/%APP_ID%/%APP_VERSION%/

http://fligtar.khan.mozilla.org/addons/trunk/site/blocklist/1/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/3.0b5/

Comment 5

[Justin Scott [:fligtar]]

Attachment: blocklist xml, v2

The previous targetApp property was wrong and I realized we don't need it anyway since this should be blocklisted in every app.

New SQL:
INSERT INTO blitems (guid, min, max) VALUES ('[e-mail]','2.0','2.0');

Comment 6

[Justin Scott [:fligtar]]

It's been blocklisted and tested in production.

Comment 7

[Daniel Veditz [:dveditz]]

Thanks!