Closed Bug 432736 Opened 13 years ago Closed 13 years ago

Blocklist vietnamese language pack 2.0

Categories

(Toolkit :: Blocklist Policy Requests, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dveditz, Assigned: fligtar)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Due to unwanted virus-droppings in help we should blocklist the Vietnamese Language Pack version 2.0.  Version 2.0.0.9 is OK, but AMO considers it older so people are getting the 2.0 version.

This is AMO number 5954,
em:id="langpack-vi-VN@firefox.mozilla.org"
and by "we should" I mean "do it ASAP". Basil has signed off on this.
Assignee: nobody → fligtar
Something like this for the SQL?

insert into blitems(guid,min,max)
values('langpack-vi-VN@firefox.mozilla.org','2.0','2.0');
insert into blapps(blitem_id, guid, min, max) values((select id from blitems
where guid = 'langpack-vi-VN@firefox.mozilla.org'),
'{ec8030f7-c20a-464f-9b0e-13a3a9e97384}', '*', '*');

If I have everything correct, that should blocklist v2.0 of the add-on on all versions of Firefox. Is that what you want?
Group: update-security
Group: update-security
If possible can we at the same time make the "older" version 2.0.0.9 available for users? At least they'd have something they could go back/up to, and the difference (other than the virus droppings) is only in a couple cookie.dtd strings -- not a big change even if the old text is wrong somehow.
Attached file blocklist xml (obsolete) —
This is the current blocklist xml with a variation of reed's SQL run. Testing it to make sure it works properly.

If anyone else on VPN wants to test, extensions.blocklist.url = http://fligtar.khan.mozilla.org/addons/trunk/site/blocklist/1/%APP_ID%/%APP_VERSION%/

http://fligtar.khan.mozilla.org/addons/trunk/site/blocklist/1/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/3.0b5/
Attachment #320007 - Flags: review?(morgamic)
Attachment #320007 - Flags: review?(morgamic)
Attached file blocklist xml, v2
The previous targetApp property was wrong and I realized we don't need it anyway since this should be blocklisted in every app.

New SQL:
INSERT INTO blitems (guid, min, max) VALUES ('langpack-vi-VN@firefox.mozilla.org','2.0','2.0');
Attachment #320007 - Attachment is obsolete: true
Attachment #320013 - Flags: review?(morgamic)
Attachment #320013 - Flags: review?(morgamic) → review+
Blocks: 432854
Depends on: 432856
It's been blocklisted and tested in production.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Thanks!
Product: addons.mozilla.org → Toolkit
You need to log in before you can comment on or make changes to this bug.