432764 - sleep times need to be increased for running talos on n810s

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Doug Turner (:dougt)]

I have found that I was required to increase the sleep timeouts in talos in order to get around a error that said the process was still running between tests.  It is as if talos isn't waiting for browser to be completely killed.  I read over the code, and it looks like we already make assumptions about waiting a set about of time using sleep before continuing.  Maybe we should simply increase this time via a new browser config option, or do something link spin until the process is no longer present before continuing?

Alice?

Comment 1

[alice nodelman [:alice] [:anode]]

Which timeout are you altering?  From my look at the code talos seems to assume that the browser (or whatever) will have closed after it receives information through javascript.dump.  Does xulrunner need longer to shutdown?

It would be possible to just spin on a check to see if the browser exists though we'd want to have some bail out clause so that we wouldn't end up there forever if things really are busted.

Comment 2

[Doug Turner (:dougt)]

i am alerting all sleep() alls to be 60s.  xulrunner on the device takes alot longer to exit.

Comment 3

[Doug Turner (:dougt)]

-> default

Comment 4

[alice nodelman [:alice] [:anode]]

Is this timeout increase still required?

Comment 5

[Doug Turner (:dougt)]

alice, needs to be tested, but you should probably make this a config option.

Comment 6

[alice nodelman [:alice] [:anode]]

Attachment: [Checked in]make browser wait times configurable

Adds a 'browser_wait' option to the talos configuration which specifies how long the browser is expected to take to open/close.

I wonder if we can get around some of these time.sleep's with waits... but we could leave that for another day.

Comment 7

[alice nodelman [:alice] [:anode]]

Comment on attachment 351112 [details] [diff] [review]
[Checked in]make browser wait times configurable

Checking in ffprocess.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess.py,v  <--  ffprocess.py
new revision: 1.9; previous revision: 1.8
done
Checking in ffprocess_linux.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess_linux.py,v  <--  ffprocess_linux.py
new revision: 1.10; previous revision: 1.9
done
Checking in ffprocess_mac.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess_mac.py,v  <--  ffprocess_mac.py
new revision: 1.11; previous revision: 1.10
done
Checking in ffsetup.py;
/cvsroot/mozilla/testing/performance/talos/ffsetup.py,v  <--  ffsetup.py
new revision: 1.7; previous revision: 1.6
done
Checking in run_tests.py;
/cvsroot/mozilla/testing/performance/talos/run_tests.py,v  <--  run_tests.py
new revision: 1.33; previous revision: 1.32
done
Checking in sample.config;
/cvsroot/mozilla/testing/performance/talos/sample.config,v  <--  sample.config
new revision: 1.21; previous revision: 1.20
done
Checking in ttest.py;
/cvsroot/mozilla/testing/performance/talos/ttest.py,v  <--  ttest.py
new revision: 1.18; previous revision: 1.17
done

Comment 8

[alice nodelman [:alice] [:anode]]

Pushed to production, looks to be behaving a-okay on active talos boxes.