432778 - Searching on Tags doesn't give back any results

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050606 Minefield/3.0pre ID:2008050606

When I do a search within the Library after I have selected the "Tags" container, no results are returned. As bug 405887 comment 37 states the search should be run against "All Bookmarks" which is also done when selecting a special tag.

Steps:
1. Bookmark a page like: http://www.google.com
2. Open the Library and select the "Tags" container within the left pane
3. Enter "Google" within the search field and press enter/return

The search should be run against "All Bookmarks" with the lately added bookmark as result. But nothing is found.

Not tested yet if this is a regression but could probably related to bug 405887.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

i was sure this was working... looking for a regression range

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

so, we are pushing &type=6 into the search result, we are really doing the same also in tag containers but that works because is returning uri results, actually type is not needed for the search, could be used in future to make search correctly looking only into tagged items or tag containers. We don't find anything because type=6 is a containers query.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #2)
> actually type is not needed for the search, could be used in future to make
> search correctly looking only into tagged items or tag containers. We don't
> find anything because type=6 is a containers query.

For the future I filed bug 432779 as a RFE. 

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch

force RESULTS_AS_URI when searching into all bookmarks

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 319972 [details] [diff] [review]
patch

r=me thanks

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/9cf7e835d062

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080808120213 Minefield/3.1a2pre ID:20080808120213

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080808031528 Minefield/3.1a2pre ID:20080808031528

Comment 8

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=7504 was created on litmus  3.1 test run for regression testing.

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv