43279 - Sidebar search textfield should use oninput event, not onkeypress

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P3)

Description

[Blake Ross]

From the sidebar Search tab, if you paste text into the textfield, the search 
button won't enable and thus you can't search.  My fault, will fix.  For now, 
work around is just to hit home or end, or any of the arrow keys.  Once the 
oninput enderlite problem is fixed, I'll change the event being fired to 
oninput instead of onkeypress, and that will fix this (and will also make this 
compatible for when textfield context menus finally land)

Comment 1

[Blake Ross]

Also just noticed the following two problems with using onkeypress:

* Highlighting all of the text in the search textfield and pressing Ctrl+X (on 
win32) or choosing Cut or Delete from the Edit menu won't disable the search 
button, as it should.

* Pasting text into the textfield using the Paste command on the Edit menu 
won't enable the search button if the textfield was empty before doing so 
(workaround described in original report).

Thus, I'm going to make this bug into the fact that the textfield should look 
for changes using the oninput event, rather than the onkeypress event, which 
will fix all of these problems.  Currently blocked by bug 42045.

Comment 2

[Blake Ross]

Should be fixed.  Claudius, please test each case when verifying this.  Thanks!

Comment 3

[Claudius Gayle]

VERIFIED Fixed 2000083008 builds