432818 - Moving a tab for channel simply called "#" triggers errors

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[funfonex]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: ChatZilla 0.9.82 [Firefox 2.0.0.14/2008040413]

Trying to move the tab for a channel whose name is simply a single hash sign triggers weird behavior; movement of the server tab, after which moving the server tab moves the hash tab...

Reproducible: Always

Steps to Reproduce:
1. join a channel called "#".
2. try to move the tab around
Actual Results:  
Moves wrong tabs.

Expected Results:  
Move the hash sign correctly.

Comment 1

[James Ross]

Heh, sounds very weird to look at. Can you tell me what URL appears in the top-left corner of the chat area for the channel?

My guess is that we're producing the URL irc://server/ which is of course identical to the URL for the server! The CIRCChannel.prototype.getURL code should add the condition of (target.length > 1) to the bit that removes the leading character.

That should cause us to assign the channel the URL irc://server/%23, which is unique and should fix the tab-moving.

Comment 2

[funfonex]

You are indeed right; the URL is simply irc://server/ instead of irc://server/%23 

Comment 3

[:Gijs (he/him)]

I can repro this, confirming, I'll try a patch in a few minutes.

Comment 4

[:Gijs (he/him)]

Attachment: Patch

Patch per Silver's comment. Tested, works.

Comment 5

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/js/lib/irc.js;
/cvsroot/mozilla/extensions/irc/js/lib/irc.js,v  <--  irc.js
new revision: 1.122; previous revision: 1.121
done