Closed
Bug 432818
Opened 16 years ago
Closed 16 years ago
Moving a tab for channel simply called "#" triggers errors
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: funfonex, Assigned: Gijs)
Details
(Whiteboard: [cz-0.9.82.1])
Attachments
(1 file)
933 bytes,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14 Build Identifier: ChatZilla 0.9.82 [Firefox 2.0.0.14/2008040413] Trying to move the tab for a channel whose name is simply a single hash sign triggers weird behavior; movement of the server tab, after which moving the server tab moves the hash tab... Reproducible: Always Steps to Reproduce: 1. join a channel called "#". 2. try to move the tab around Actual Results: Moves wrong tabs. Expected Results: Move the hash sign correctly.
Comment 1•16 years ago
|
||
Heh, sounds very weird to look at. Can you tell me what URL appears in the top-left corner of the chat area for the channel? My guess is that we're producing the URL irc://server/ which is of course identical to the URL for the server! The CIRCChannel.prototype.getURL code should add the condition of (target.length > 1) to the bit that removes the leading character. That should cause us to assign the channel the URL irc://server/%23, which is unique and should fix the tab-moving.
Version: unspecified → Trunk
Updated•16 years ago
|
Hardware: PC → All
You are indeed right; the URL is simply irc://server/ instead of irc://server/%23
Assignee | ||
Comment 3•16 years ago
|
||
I can repro this, confirming, I'll try a patch in a few minutes.
Assignee: rginda → gijskruitbosch+bugs
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•16 years ago
|
||
Patch per Silver's comment. Tested, works.
Attachment #320036 -
Flags: review?(silver)
Updated•16 years ago
|
Attachment #320036 -
Flags: review?(silver) → review+
Assignee | ||
Comment 5•16 years ago
|
||
Checking in mozilla/extensions/irc/js/lib/irc.js; /cvsroot/mozilla/extensions/irc/js/lib/irc.js,v <-- irc.js new revision: 1.122; previous revision: 1.121 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.82.1]
You need to log in
before you can comment on or make changes to this bug.
Description
•