432910 - Mid-Air Collision checking for Bug.update()

Status: NEW

(Bugzilla :: WebService, enhancement)

Description

[Max Kanat-Alexander]

Implement an optional parameter for the Bug.update() WebService call, called check_collision, which takes a date.

If this is specified and there's been a mid-air collision since that time, we will return an item called 'collision' that is a hash representing the changes since that time and who made them.

Comment 1

[Max Kanat-Alexander]

As I started to implement this, I realized that it was entirely handled by bug 424079--that is, once we have get_activity, we can actually just call it directly from Bug.update() when there's a midair collision. So I attached the code that I had for this to bug 424079 for nelwahar to add in to his code.

Comment 2

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.

Comment 3

[Frank Becker]

Attachment: 432910_V1.patch

I developed this for the Mylyn Bugzilla REST API connector.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 816342 [details] [diff] [review]
432910_V1.patch

Review of attachment 816342 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for taking so long to get to this :( Unfortunately there is some bit rot and needs to be updated. Let me know if you no longer want to work on this as well and I can take it over.

dkl

::: Bugzilla/WebService/Bug.pm
@@ +3868,4 @@
>  
>  =item REST API call added Bugzilla B<5.0>.
>  
> +=item Add Returnfield "collision" in Bugzilla B<5.0>.

s/collision/collisions/

Comment 5

[Frank Becker]

(In reply to David Lawrence [:dkl] from comment #4)
> Comment on attachment 816342 [details] [diff] [review]
> 432910_V1.patch
> 
> Review of attachment 816342 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Sorry for taking so long to get to this :( Unfortunately there is some bit
> rot and needs to be updated. Let me know if you no longer want to work on
> this as well and I can take it over.
> 
> dkl

It would be great if you continue with this.

Frank

Comment 6

[Graham Perrin]

Attachment: Screenshot: a reported collision

Please, is this still an issue?

For what it's worth: I do often encounter reported mid-air collisions (with Bugzilla for FreeBSD) however to the best of my recollection, there has never been a meaningful report.

In the attached example, 'Submit my changes anyway' caused nothing to be overwritten (neither of the cc recipients were removed). If there's nothing to be overwritten, why the report?

Comment 7

[David Lawrence [:dkl]]

(In reply to Graham Perrin from comment #6)

In the attached example, 'Submit my changes anyway' caused nothing to be overwritten (neither of the cc recipients were removed). If there's nothing to be overwritten, why the report?

Because the changes made may influence your changes as well so you are given a chance to change yours.

Comment 8

[Taryn Troutman]

Attachment: same problem

Thanks from dongtaragast1986.