432998 - Creating event ignores selected date and creates event for today

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Pete Riley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: Lightning 0.9pre 2008-05-08 20 / Thunderbird 2.0.0.14

Event dialog ignores double-clicked day when create new event.

Reproducible: Always

Steps to Reproduce:
1) In month view, double click a day in the future to create a new event.

Actual Results:  
The Start date in the event dialog is always today.

Expected Results:  
The Start date should be the same as the day on which I double clicked.

Comment 1

[Stefan Sitter [:ssitter]]

Regression range: Works in Sunbird 0.9pre (2008-05-06-18)
                  Fails in Sunbird 0.9pre (2008-05-07-12)

Checkins during regression range: http://tinyurl.com/6y57uv

Probably regressed by Bug 428715.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

My bug, again. I'll be taking care.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This bug fixes the regression, and also fixes bug 390020. Note this patch might cause further regressions, please review carefully (not due to the fact that I'm including a fix to bug 390020!):

-        } else if (aStartTime && aStartTime.isDate) {
-            var event = createEvent();
-            event.startDate = aStartTime;
-            setDefaultAlarmValues(event);
-            doTransaction('add', event, aCalendar, null, null);
         } else {

I looked through the code and could fine nothing that would trigger such a case. The only place that createNewEvent was being called was when dragging in the "new" mode and when doubleclicking. It didn't look like this piece of code would ever be hit. I needed to remove that to make sure that its possible to pass all-day start dates, to either force it to be an allday event or to fit the hour to an existing date. The doubleclicking is passed quite controlled, so the only place I can imagine this is needed would be during dragging.

Comment 4

[Stefan Sitter [:ssitter]]

Regression also applies for events created via menu entry, toolbar button, keyboard shortcut and context menu. 

Comment 5

[Martin Schröder [:mschroeder]]

Comment on attachment 320464 [details] [diff] [review]
Fix - v1

Like Stefan mentioned, when creating a new event via menu entry, toolbar button, keyboard shortcut and context menu this doesn't work. Also with the patch applied today's date is picked for these ways to create an event, but the views work nicely again.

r-

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

This patch should take care. I wasn't aware we were using the selected day.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v3

It seems a chunk was missing, here it is.

Comment 8

[Martin Schröder [:mschroeder]]

Comment on attachment 321994 [details] [diff] [review]
Fix - v3

r=mschroeder

Comment 9

[Martin Schröder [:mschroeder]]

Checked in on HEAD and MOZILLA_1_8_BRANCH (as requested from Philipp)

-> FIXED

Comment 10

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/2008052220 Calendar/0.9pre.