433089 - <area> test for bug 409604 is unreliable

Status: REOPENED

(Core :: DOM: Events, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

I had to disable part of the test for bug 409604 because it was not passing reliably on the unit test machines.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/content/events/test&command=DIFF_FRAMESET&file=test_bug409604.html&rev1=1.3&rev2=1.4&root=/cvsroot

The "click" event for that testcase wasn't firing consistently. I could reproduce locally if I blanked out the src="" attribute of the image so that no image was loaded, so it might have to do with image loading being too slow on the test machines or something.

Comment 1

[(no longer active)]

Hmmm, I can reproduce it by setting the src attribute to an invalid value as well.  But the time it takes to load the image shouldn't be a factor.  I tested with a very large image <http://benjamin.smedbergs.us/blog/wp-content/uploads/2008/05/maddie-newborn.png> which takes quite a bit of time to load on my connection, and the test did not start until the image was fully loaded (and passed successfully as soon as the image was loaded completely).

I'm investigating this further.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

We block onload on the image loading, and the test runs onload, so the image must be failing to load entirely if that is indeed the failure case. I'm not sure what would cause that.

Comment 3

[(no longer active)]

In bonsai, I see that you had tried an image with a data: URI.  Did that help the instability of the area test?

Comment 4

[(no longer active)]

Attachment: Patch (v1)

This patch tries to check if the image is loaded or not.  If it's not loaded for some reason, it dynamically disables the <area> test so that the test case does not fail.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

The data: URI didn't help.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 320379 [details] [diff] [review]
Patch (v1)

This looks OK, but I don't see how it will help. The data URL shouldn't be able to fail to load.

Comment 7

[(no longer active)]

I guess there's still room for more investigation on this, but it may be worth to add this check to the unit test for now.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/066b5a78cc46

Comment 9

[Dão Gottwald [:dao]]

backed out because of test failures:

*** 5934 ERROR FAIL | (click) unexpected element: c expected: b |  | /tests/content/events/test/test_bug409604.html
*** 5938 ERROR FAIL | (click) unexpected element: e expected: c |  | /tests/content/events/test/test_bug409604.html
*** 5940 ERROR FAIL | (click) unexpected element: f expected: e |  | /tests/content/events/test/test_bug409604.html
*** 5946 ERROR FAIL | (click) unexpected element: i expected: f |  | /tests/content/events/test/test_bug409604.html
*** 5948 ERROR FAIL | (click) unexpected element: j expected: i |  | /tests/content/events/test/test_bug409604.html
*** 5956 ERROR FAIL | (click) unhandled elements remaining: j |  | /tests/content/events/test/test_bug409604.html
*** 6504 ERROR FAIL | Typed 'Test' after three left-arrows starting from end | got "abcdefgh", expected "abcdeTestfgh" | /tests/content/html/content/test/test_bug300691-1.html
*** 6506 ERROR FAIL | Backspaced twice after two right-arrows starting from end of typing | got "abcdefgh", expected "abcdeTesth" | /tests/content/html/content/test/test_bug300691-1.html
*** 6508 ERROR FAIL | Appending textnode shouldn't affect value in edited textarea | got "abcdefghijk", expected "abcdeTesth" | /tests/content/html/content/test/test_bug300691-1.html
*** 6510 ERROR FAIL | Modifying textnode text shouldn't affect value in edited textarea | got "abcdefghlmno", expected "abcdeTesth" | /tests/content/html/content/test/test_bug300691-1.html
*** 6512 ERROR FAIL | Removing child textnode shouldn't affect value in edited textarea | got "defghlmno", expected "abcdeTesth" | /tests/content/html/content/test/test_bug300691-1.html
*** 6514 ERROR FAIL | Inserting child textnode shouldn't affect value in edited textarea | got "abcdefghlmno", expected "abcdeTesth" | /tests/content/html/content/test/test_bug300691-1.html
*** 6516 ERROR FAIL | Normalization changes nothing for the value 3 | got "abcdefghlmno", expected "abcdeTesth" | /tests/content/html/content/test/test_bug300691-1.html
*** 6518 ERROR FAIL | Setting default value shouldn't affect edited textarea | got "abc", expected "abcdeTesth" | /tests/content/html/content/test/test_bug300691-1.html
*** 7157 ERROR FAIL | undefined | got "input1", expected "input2" | /tests/content/html/content/test/test_bug386996.html


http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1215813119.1215816945.24302.gz

Comment 10

[Janelle Maughan]

Attachment: same problem

Thanks from pregrefilo1973.