Closed
Bug 433179
Opened 13 years ago
Closed 12 years ago
Tag container icon wrong when tag folder is empty
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.1b3
People
(Reporter: micmon, Assigned: mak)
Details
(Keywords: polish, verified1.9.1)
Attachments
(1 file)
2.85 KB,
patch
|
mano
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
The tag folder uses the smart bookmark icon if it is empty, e.g. if you have not created any tags before. Tested with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008051008 Minefield/3.0pre and also confirmed for Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008051008 Minefield/3.0pre
Reporter | ||
Comment 1•13 years ago
|
||
I can also confirm this on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050920 Minefield/3.0pre so it affects all platforms (changing OS to all). Note: after setting a tag you have to click the tag folder once to make it change.
OS: Linux → All
Assignee | ||
Comment 2•13 years ago
|
||
that's because if hasChildren returns false we don't consider it a container, so we don't apply the correct icon since it requires the "container" attribute
Assignee | ||
Comment 3•13 years ago
|
||
see comment above
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs review mano]
Comment on attachment 341287 [details] [diff] [review] patch r=mano
Attachment #341287 -
Flags: review?(mano) → review+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs review mano]
Target Milestone: --- → Firefox 3.1
Assignee | ||
Comment 5•12 years ago
|
||
pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/9287d4e1dd6f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Attachment #341287 -
Flags: approval1.9.1?
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 341287 [details] [diff] [review] patch asking approval 1.9.1. Polish fix, no risk.
Updated•12 years ago
|
Attachment #341287 -
Flags: approval1.9.1? → approval1.9.1+
Comment 7•12 years ago
|
||
Comment on attachment 341287 [details] [diff] [review] patch a191=beltzner
Assignee | ||
Comment 8•12 years ago
|
||
pushed to 1.9.1 branch: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c026a7fe07d1
Keywords: fixed1.9.1
Target Milestone: Firefox 3.1 → Firefox 3.1b3
Comment 9•12 years ago
|
||
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090203 Shiretoko/3.1b3pre
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Keywords: fixed1.9.1 → verified1.9.1
Comment 10•11 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•