433179 - Tag container icon wrong when tag folder is empty

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Michael Monreal [:micmon]]

The tag folder uses the smart bookmark icon if it is empty, e.g. if you have not created any tags before. Tested with

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008051008 Minefield/3.0pre

and also confirmed for

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008051008 Minefield/3.0pre

Comment 1

[Michael Monreal [:micmon]]

I can also confirm this on

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre)
Gecko/2008050920 Minefield/3.0pre

so it affects all platforms (changing OS to all).

Note: after setting a tag you have to click the tag folder once to make it change.

Comment 2

[Marco Bonardo [:mak]]

that's because if hasChildren returns false we don't consider it a container, so we don't apply the correct icon since it requires the "container" attribute

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch

see comment above

Comment 4

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

Comment on attachment 341287 [details] [diff] [review]
patch

r=mano

Comment 5

[Marco Bonardo [:mak]]

pushed to trunk:
http://hg.mozilla.org/mozilla-central/rev/9287d4e1dd6f

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 341287 [details] [diff] [review]
patch

asking approval 1.9.1.
Polish fix, no risk.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 341287 [details] [diff] [review]
patch

a191=beltzner

Comment 8

[Marco Bonardo [:mak]]

pushed to 1.9.1 branch:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c026a7fe07d1

Comment 9

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090203 Shiretoko/3.1b3pre

Comment 10

[Gervase Markham [:gerv] (not reading bugmail)]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv