netError favicon broken on Linux; uses last page's favicon

RESOLVED FIXED in Firefox 3

Status

()

defect
--
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: davemgarrett, Assigned: Gavin)

Tracking

({polish, regression})

Trunk
Firefox 3
x86
Linux
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 obsolete attachments)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008051009 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008051009 Minefield/3.0pre

The netError favicon seems to be broken on Linux now.

Reproducible: Always

Steps to Reproduce:
1.  Goto any site with a favicon (i.e. Bugzilla)
2.  Goto http://www.adgasdgasdgasdgawg.com/  (non-existent site) in same tab
3.  Note the favicon is of step #1's site



My guess is this is related to the patch from bug 432938.
Keywords: polish, regression
Blocks: 432938
Version: unspecified → Trunk
I can confirm that I get the wrong icon displayed with recently nightlies in Ubuntu Hardy.  It seems that the moz-icon://stock/gtk-dialog-warning?size=men icon is ignored when specified here.  (I do get the proper warning icon when displaying that image in other ways than as a favicon)
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox3?
I can also confirm this on Ubuntu hardy. This is the regression window:

Does not repro in:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050904 Minefield/3.0pre
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050918 Minefield/3.0pre


Does repro in:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008051004 Minefield/3.0pre

My opinion is that this wouldn't block final release, and is something we could fix in a security & stability release.
It does not affect all favicon pages. For instance:

1. go to http://en.wikipedia.org/wiki/American_robin
2. at the bottom of the page (under "External Links") click the "eNature Profile" hyperlink
3. the wikipedia favicon does not stay despite the eNature site not defining their down favicon (as far as I can see)
Posted patch fix (obsolete) — Splinter Review
The moz-icon scheme needs to be exempted for error pages.  Don't think that this is blocking, but if there is going to be a respin for another bug, then perhaps this could be included.
Assignee: nobody → kliu
Status: NEW → ASSIGNED
Attachment #320437 - Flags: review?(gavin.sharp)
Agreed it shouldn't block. So I'm going to minus the blocking but nom the patch for approval so we don't miss it if we happen to have to do an RC2
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Attachment #320437 - Flags: approval1.9?
Does that mean that this is more than Linux-only?
Flags: wanted1.9.0.x+
Comment on attachment 320437 [details] [diff] [review]
fix

Sorry, Schrep - we should only be marking bugs for approval once the patches have been reviewed.
Attachment #320437 - Flags: approval1.9?
Flags: wanted-firefox3+
Whiteboard: [RC2]
Whiteboard: [RC2] → [RC2?]
A moz-icon URI for the favicon is used only for GTK2, so this is Linux-only.
Oops, forgot to update the comment.

(In reply to comment #7)
> Does that mean that this is more than Linux-only?
> 
To elaborate on the response given in comment 9, if the Windows or Mac error pages had tried to use a moz-icon favicon, they'd be affected too (this allowed me to test the patch even though I don't have a Linux box handy), so this is all-platforms in theory, but Linux-only in practice.
Attachment #320437 - Attachment is obsolete: true
Attachment #320444 - Flags: review?(gavin.sharp)
Attachment #320437 - Flags: review?(gavin.sharp)
I fixed this by backing out the patch for bug 432938, per RC1 thread on dev.planning and #developers. We should roll the patch in this bug into subsequent patches for bug 432938.
Assignee: kliu → gavin.sharp
Status: ASSIGNED → NEW
Whiteboard: [RC2?]
Target Milestone: --- → Firefox 3
Attachment #320444 - Attachment is obsolete: true
Attachment #320444 - Flags: review?(gavin.sharp)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 3 → ---
Thanks for jumping in and patching this, Kai.
Target Milestone: --- → Firefox 3
(even if we didn't end up taking the patch right away)
Flags: wanted1.9.0.x+
You need to log in before you can comment on or make changes to this bug.