433317 - Renamed title of saved search folder isn't updated outside the Library until Firefox is restarted

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008051204 Minefield/3.0pre and on Windows XP.

If you rename a saved search folder e.g. "Most Visited" its title is not updated until you restart the browser.

Steps:
1. Create a fresh profile
2. Open context menu of "Bookmarks Toolbar" and choose properties for "Most Visited"
3. Rename it to "Most" and click ok

The title doesn't change on the "Bookmarks Toolbar" until you restart the browser. Inside the Library the folder shows its new name. Same happens for search folders under the "Bookmarks Menu".

Comment 1

[Dietrich Ayala (:dietrich)]

In the library, the change only shows if you refresh the view (by viewing another folder, etc, and coming back).

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

this fixes the treeview. haven't tested the menu on windows yet.

Comment 3

[Dietrich Ayala (:dietrich)]

Attachment: with test

but doesn't fix toolbar or menu, so not yet complete

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: fix v2

refresh contents and update node (causing views to be notified). building windows now to test menu updates there.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 320851 [details] [diff] [review]
fix v2

+  var histsvc = Cc["@mozilla.org/browser/nav-history-service;1"].getService(Ci.nsINavHistoryService);
+  var bmsvc = Cc["@mozilla.org/browser/nav-bookmarks-service;1"].getService(Ci.nsINavBookmarksService);
+
+  // create a query bookmark
+  var queryId = bmsvc.insertBookmark(bmsvc.toolbarFolder, uri("place:"), 0 /* first item */, "test query");

try catch for services and crop at 80

Comment 6

[Dietrich Ayala (:dietrich)]

Attachment: nit fixed

Comment 7

[(mostly gone) XtC4UaLL [:xtc4uall]]

can Bug 433272 be considerated as a dupe of this concerning updating of *all* "special" items?

Comment 11

[Asaf Romano (gone)]

Comment on attachment 320914 [details] [diff] [review]
nit fixed

r=mano

Comment 12

[Dietrich Ayala (:dietrich)]

changeset:   15658:1d16c9f72c8d

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1a1pre) Gecko/2008070402 Minefield/3.1a1pre ID:2008070402

The patch contains an unit test. I hope it's ok to set in-testsuite+.

Comment 14

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Hey Dietrich, the test did not got checked-in? i can't find it and the changeset log does not include it

http://hg.mozilla.org/mozilla-central/rev/1d16c9f72c8d

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Reverting in-testsuite+ flag until its clear what happened with the check-in.

Comment 16

[Dietrich Ayala (:dietrich)]

pushed the test: http://hg.mozilla.org/mozilla-central/rev/c57ea0aac0d0

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv