Closed Bug 433390 Opened 12 years ago Closed 12 years ago

build logs should show what source code was pulled

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(1 file)

The tinderbox build logs should show what source code was pulled.  I think the best way to do this is actually to add to client.py, which will make this output part of anybody else's build log as well.  (It's analogous to the way the client.mk checkout target printed start and end times for the CVS pull.)

I think we should:
 * show the output of hg parent after each hg pull
 * show a timestamp before and after each cvs pull (or maybe just before/after the whole thing)
Attached patch possible patchSplinter Review
I'm not sure if this is too noisy (or who should review it).
Comment on attachment 320596 [details] [diff] [review]
possible patch

What do you think of this?  I want it mainly for build logs (e.g., tinderbox), but I don't see any reason not to show it to everyone.
Attachment #320596 - Flags: review?(jorendorff)
Attachment #320596 - Flags: review?(ted.mielczarek)
Comment on attachment 320596 [details] [diff] [review]
possible patch

I'm not worried about this script being noisy.  Check it in if it'll help you!

I think we need a better approach to this stuff long-term, but this isn't the venue.
Attachment #320596 - Flags: review?(jorendorff) → review+
Attachment #320596 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → dbaron
http://hg.mozilla.org/mozilla-central/index.cgi/rev/75f25ddb2329
 --> fixed
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0
Target Milestone: mozilla2.0 → mozilla1.9.1
Target Milestone: mozilla1.9.1 → mozilla1.9.1a1
Depends on: 447667
No longer depends on: 447667
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.