433500 - IMIP bar does not display anymore [Error: identity.toLowerCase is not a function]

Status: VERIFIED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[klint]

User-Agent:       BlackBerry8830/4.2.2 Profile/MIDP-2.0 Configuration/CLOC-1.1 VendorID/105
Build Identifier: TB 2.0.0.14 + Lightning 20080512

When displaying a mail containing an invitation, the IMIP bar does not display anymore ( Note: "view messages inline" is activated).
The message body is displayed correctly.


Reproducible: Always

Steps to Reproduce:
1.Move to a mail with an invitation
2.
3.
Actual Results:  
the imip bar is not ther

Expected Results:  
the imap bar should be displayed

The console shows the following error:
Erreur : identity.toLowerCase is not a function
Fichier source : chrome://lightning/content/imip-bar.js
Ligne : 383

Comment 1

[Stefan Sitter [:ssitter]]

Should identity.toLowerCase be identity.email.toLowerCase as a few lines below? http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/calendar/lightning/content/imip-bar.js&rev=1.17&mark=383,389#369

Comment 2

[Daniel Boelzle [:dbo]]

I think so:
<http://mxr.mozilla.org/mozilla1.8/source/mailnews/base/public/nsIMsgIdentity.idl#67>

Comment 3

[klint]

I do confirm your assumption: I don't know how to develop a patch (sorry!), but I have applied the change on my Lightning installation, and it solves the issue.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

klint, take a look at http://wiki.mozilla.org/Calendar:Build

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Patch v1

The patch adds the necessary code as described in comment 1 and removes two stray whitespaces at lineends.

Comment 6

[Daniel Boelzle [:dbo]]

Comment on attachment 320981 [details] [diff] [review]
Patch v1

r=dbo

Comment 7

[Simon Paquet [:sipaq]]

Fix checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 8

[Andreas Treumann]

Verified in nightly build 2008073004 -> VERIFIED