Closed Bug 4336 Opened 25 years ago Closed 24 years ago

MLK: 5632 bytes leaked- www.visa.com - [top100]leaking StyleContextImpl

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: bruce, Assigned: pollmann)

References

()

Details

(Keywords: memory-leak, top100)

This leak happens when visiting the Visa website.  Build from March 27, 1999.

MLK: 5632 bytes leaked in 11 blocks
  * This memory was allocated from:
        malloc         [rtlib.o]
        __bUiLtIn_nEw  [libgcc.a]
        __builtin_new  [rtlib.o]
        StyleContextImpl::operator  new(unsigned int) [nsStyleContext.cpp:839]

NS_NewStyleContext(nsIStyleContext**,nsIStyleContext*,nsIAtom*,nsISupportsArray*
,nsIPresContext*) [nsStyleContext.cpp:1514]

StyleSetImpl::GetContext(nsIPresContext*,nsIStyleContext*,nsIAtom*,nsISupportsAr
ray*,int,int&) [nsStyleSet.cpp:453]

StyleSetImpl::ResolveStyleFor(nsIPresContext*,nsIContent*,nsIStyleContext*,int)
[nsStyleSet.cpp:546]

nsPresContext::ResolveStyleContextFor(nsIContent*,nsIStyleContext*,int,nsIStyleC
ontext**) [nsPresContext.cpp:384]

nsCSSFrameConstructor::ResolveStyleContext(nsIPresContext*,nsIFrame*,nsIContent*
,nsIAtom*,nsIStyleContext**) [nsCSSFrameConstructor.cpp:2838]

nsCSSFrameConstructor::ConstructFrame(nsIPresContext*,nsIContent*,nsIFrame*,nsAb
soluteItems&,nsFrameItems&,nsAbsoluteItems&,nsAbsoluteItems&)
[nsCSSFrameConstructor.cpp:2861]

nsCSSFrameConstructor::ContentInserted(nsIPresContext*,nsIContent*,nsIContent*,i
nt) [nsCSSFrameConstructor.cpp:3418]

nsCSSFrameConstructor::RecreateFramesForContent(nsIPresContext*,nsIContent*)
[nsCSSFrameConstructor.cpp:4571]

nsCSSFrameConstructor::AttributeChanged(nsIPresContext*,nsIContent*,nsIAtom*,int
) [nsCSSFrameConstructor.cpp:3953]
        StyleSetImpl::AttributeChanged(nsIPresContext*,nsIContent*,nsIAtom*,int)
[nsStyleSet.cpp:793]
        PresShell::AttributeChanged(nsIDocument*,nsIContent*,nsIAtom*,int)
[nsPresShell.cpp:1626]
        nsDocument::AttributeChanged(nsIContent*,nsIAtom*,int)
[nsDocument.cpp:1356]
        nsGenericHTMLElement::SetHTMLAttribute(nsIAtom*,const nsHTMLValue&,int)
[nsGenericHTMLElement.cpp:665]
        nsHTMLOptionElement::SetIndex(int) [nsHTMLOptionElement.cpp:219]
        nsSelectControlFrame::Reset() [nsSelectControlFrame.cpp:709]
        nsSelectControlFrame::PostCreateWidget(nsIPresContext*,int&,int&)
[nsSelectControlFrame.cpp:594]
        nsFormControlFrame::Reflow(nsIPresContext&,nsHTMLReflowMetrics&,const
nsHTMLReflowState&,unsigned int&) [nsFormControlFrame.cpp:311]
        nsLineLayout::ReflowFrame(nsIFrame*,nsIFrame**,unsigned int&)
[nsLineLayout.cpp:841]

nsBlockFrame::ReflowInlineFrame(nsBlockReflowState&,nsLineBox*,nsIFrame*,unsigne
d char*) [nsBlockFrame.cpp:2728]
        nsBlockFrame::ReflowInlineFrames(nsBlockReflowState&,nsLineBox*,int*)
[nsBlockFrame.cpp:2610]
        nsBlockFrame::ReflowLine(nsBlockReflowState&,nsLineBox*,int*)
[nsBlockFrame.cpp:1717]
        nsBlockFrame::ReflowDirtyLines(nsBlockReflowState&)
[nsBlockFrame.cpp:1522]
        nsBlockFrame::Reflow(nsIPresContext&,nsHTMLReflowMetrics&,const
nsHTMLReflowState&,unsigned int&) [nsBlockFrame.cpp:892]
        nsAreaFrame::Reflow(nsIPresContext&,nsHTMLReflowMetrics&,const
nsHTMLReflowState&,unsigned int&) [nsAreaFrame.cpp:509]

nsContainerFrame::ReflowChild(nsIFrame*,nsIPresContext&,nsHTMLReflowMetrics&,con
st nsHTMLReflowState&,unsigned int&) [nsContainerFrame.cpp:388]
        nsTableCellFrame::Reflow(nsIPresContext&,nsHTMLReflowMetrics&,const
nsHTMLReflowState&,unsigned int&) [nsTableCellFrame.cpp:501]
  * Block of 512 bytes (11 times); last block at 0x817270
Assignee: peterl → karnaze
Component: Style System → Form Submission
Changing URL to sample HTML that minimally demonstrates the leak and to form
handling code since it seems to only happen so far in display of select menus
for forms.
Assignee: karnaze → pollmann
QA Contact: 4110 → 4137
Status: NEW → ASSIGNED
Target Milestone: M7
I'm arbitrarily declaring M8 my UMR/MLK milestone.  :)
I still haven't got Purify working on Solaris, and won't receive Purify for NT
for a few weeks.  Marking these M10
Summary: MLK: leaking StyleContextImpl → MLK: 5632 bytes leaked- www.visa.com - [top100]leaking StyleContextImpl
Blocks: 14516
After careful consideration, I've decided that I probably won't get this bug in
for M12.  Currently I have nearly 50 bugs scheduled for M13, so there is a
possibility that this bug may need to be moved out farther still.
QA Contact update.
Target Milestone: M13 → M14
Triaged to M14
Keywords: mlk
adding top100 keyword.
Keywords: top100
Moving off to M16 - please speak up of you need this for M14, thanks!
Target Milestone: M14 → M16
Rescheduling (*sigh*)  Some of these are from M4.  I wonder if they are all
still valid?
Target Milestone: M16 → M17
We are no longer leaking StyleContextImpl's.  In fact, I just did a walk of 
about half of the top100 (Chofmann's browser buster test).  We leaked 5 
webshells and just over 1Mb of other stuff, but no StyleContextImpl's!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → WORKSFORME
QA Contact: ckritzer → vladimire
Updating QA contact.
Verifying worksforme
Status: RESOLVED → VERIFIED
Component: HTML: Form Submission → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.