433687 - Clean up nsISmtpUrl/nsIMailtoUrl and tidy some other mailnews url functions

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix (diff -w)

As I need to do some improvements to our url handling for the password manager bugs, I want to do some to nsISmtpUrl and nsIMailtoURL. Whilst I'm in the area, I noticed some functions we no longer need/user, so I'm dropping them as well.

With the nsIMailtoURL::GetMessageContents function, I separated out the items we don't use into different attributes. This allows us to only call with the parameters we need, but allows extensions to still get to the other items. Which in turn allows us to use ACString rather than string as the idl arguements.

I also completely dropped the attachments option because of the security issues.

There's also some variable name clean up as well (drop the 'a' prefix from variables that aren't arguments).

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix (Normal patch)

Comment 2

[David :Bienvenu]

Comment on attachment 320889 [details] [diff] [review]
The fix (diff -w)

+   * recipients to send the email to. each name is NULL terminated.

Can you make that Each, i.e., fix the capitalization?

Comment 3

[Mark Banner (:standard8)]

Patch checked in with captilisation fixed.