Last Comment Bug 433703 - All-numeric channel names do not appear as links in chatzilla
: All-numeric channel names do not appear as links in chatzilla
Status: RESOLVED FIXED
[cz-0.9.83]
:
Product: Other Applications
Classification: Client Software
Component: ChatZilla (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: :Gijs Kruitbosch
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-14 07:36 PDT by Adam
Modified: 2008-06-17 14:23 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (959 bytes, patch)
2008-06-02 08:05 PDT, :Gijs Kruitbosch
bugzilla-mozilla-20000923: review+
Details | Diff | Review

Description Adam 2008-05-14 07:36:43 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: 0.9.82

Chatzilla does not recognize channel names that consist of only numbers as links, (e.g. #51 will show up for a chatzilla user as plaintext, not a clickable links).

Reproducible: Always

Steps to Reproduce:
1. Type a channel link using only numbers (i.e. #10) into chat window
2. 
3.
Actual Results:  
Chatzilla users do not see numeric channel name as link

Expected Results:  
Numeric channel names should appear as links.
Comment 1 James Ross 2008-05-16 13:20:23 PDT
The channel munger specifically ignores entirely numeric channel-like items, just as it does #define, #ifdef and a few other C/C++ syntax things.

I don't know why entirely numeric items are included and I don't want to change the list in too much of a hurry.
Comment 2 :Gijs Kruitbosch 2008-06-02 06:55:42 PDT
(In reply to comment #1)
> The channel munger specifically ignores entirely numeric channel-like items,
> just as it does #define, #ifdef and a few other C/C++ syntax things.
> 
> I don't know why entirely numeric items are included and I don't want to change
> the list in too much of a hurry.
> 

Actually, I'd go for line numbers referenced somewhere, and bug numbers. However, I don't really think that that particular problem is more important than this one. We should already disable the channel linkifier inside protocol'd links as well as bug links, and if we don't we should do so if we fix this, because otherwise bonsai and lxr links will be "fun".
Comment 3 :Gijs Kruitbosch 2008-06-02 08:05:34 PDT
Created attachment 323372 [details] [diff] [review]
Patch

There we go. We test for inLink in there, and set it in protocol:, bug and email links, so I think we're safe.
Comment 4 James Ross 2008-06-02 08:14:06 PDT
Comment on attachment 323372 [details] [diff] [review]
Patch

r=silver providing you've tested all the types of munger that could be affected (normal links, mailto, etc.)
Comment 5 :Gijs Kruitbosch 2008-06-17 14:20:42 PDT
Checking in mozilla/extensions/irc/xul/content/mungers.js;
/cvsroot/mozilla/extensions/irc/xul/content/mungers.js,v  <--  mungers.js
new revision: 1.15; previous revision: 1.14
done

Note You need to log in before you can comment on or make changes to this bug.