433708 - windows debug slaves on mozilla-central do not properly dump sdleak.log

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

This is possibly related to bug 432338 though the symptoms are a little different. When running with '--shutdown-leaks sdleak.log' or '--shutdown-leaks=sdleak.log' I get a file with the shutdown leak information in it, but the filename is '????????????????????' (with a varying number of '?'s), instead of the specified filename. This is different than what's happening on fxdbug-win32-tbox, though I have a hunch the cause is the same.

I've looked at the trace-malloc code a bit and I'm lost, I could use some help here.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: possible patch

I haven't tested this yet, but you could give this a try.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 320924 [details] [diff] [review]
possible patch

I'm testing this now.

Comment 3

[[e-mail] (:bhearsum)]

sdleak.log seems to be fixed on Windows with this patch, yay :)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Pushed to mozilla-central.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

... in changeset 111c20038fa667049218d2dbc0023f54a07098b4

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And, for the record, the windows debug tinderbox went green.