Closed Bug 433798 Opened 12 years ago Closed 12 years ago

.hgignore improvement: ignore security/manager/.nss.checkout

Categories

(Firefox Build System :: General, defect)

Other Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file, 1 obsolete file)

The empty file 
   mozilla/security/manager/.nss.checkout
gets generated every time I build a fresh mozilla-central tree.

dbaron tells me that this file is just used as a flag that's generated to indicate whether we should build NSS, or something like that.

This file isn't being ignored by Mercurial, and that's bad.
e.g. suppose I edit some files and then do a "hg add".  hg captures my changes *including* the creation of the .nss.checkout file.

IMHO, we should add this file to the hgignore list, to avoid headaches / accidental incorporation into mercurial repos.
Attached patch patch v1 (obsolete) — Splinter Review
This fixes it, though I'm not sure if the explanatory comment is 100% accurate.
Attached patch patch v2Splinter Review
Improved patch:
 - Improved comment, after talking to dbaron some more
 - Escaped '.' characters
 - Added trailing $
Attachment #321010 - Attachment is obsolete: true
Attachment #321011 - Flags: review?(ted.mielczarek)
Attachment #321011 - Flags: review?(ted.mielczarek) → review+
Patch v2 committed.
Changeset 3c2a38984d4c743e6076fd54e7221c3a52999884
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.