Closed
Bug 433798
Opened 16 years ago
Closed 16 years ago
.hgignore improvement: ignore security/manager/.nss.checkout
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file, 1 obsolete file)
437 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The empty file mozilla/security/manager/.nss.checkout gets generated every time I build a fresh mozilla-central tree. dbaron tells me that this file is just used as a flag that's generated to indicate whether we should build NSS, or something like that. This file isn't being ignored by Mercurial, and that's bad. e.g. suppose I edit some files and then do a "hg add". hg captures my changes *including* the creation of the .nss.checkout file. IMHO, we should add this file to the hgignore list, to avoid headaches / accidental incorporation into mercurial repos.
Assignee | ||
Comment 1•16 years ago
|
||
This fixes it, though I'm not sure if the explanatory comment is 100% accurate.
Assignee | ||
Comment 2•16 years ago
|
||
Improved patch: - Improved comment, after talking to dbaron some more - Escaped '.' characters - Added trailing $
Attachment #321010 -
Attachment is obsolete: true
Attachment #321011 -
Flags: review?(ted.mielczarek)
Updated•16 years ago
|
Attachment #321011 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → dholbert
Assignee | ||
Comment 3•16 years ago
|
||
Patch v2 committed. Changeset 3c2a38984d4c743e6076fd54e7221c3a52999884
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•