433843 - Revise or remove getFloatingDate

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Daniel Boelzle [:dbo]]

I stumbled over calUtils.js' getFloatingDate() which has been introduced with recent minimonth changes:

1. A js Date cannot get floating, so I think the name of that function is misleading.

2. The function hardly does anything:

function getFloatingDate(aDate) {
    var d = createDateTime();
    d.timezone = floating();
    d.jsDate = aDate; // this sets 'd' UTC-based
    return d.jsDate; // this returns d in system-timezone
}

so calls like "getFloatingDate(new Date())" could be replaced by "new Date()".

I doubt that is what has been intended.

Comment 1

[Berend Cornelius]

Attachment: patch to remove the function

Comment 2

[Berend Cornelius]

Attachment: patch v.#2

improved version of the first patch

Comment 3

[Daniel Boelzle [:dbo]]

Comment on attachment 321262 [details] [diff] [review]
patch v.#2

r=dbo

Comment 4

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 5

[Andreas Treumann]

Checked on mxr.mozilla.com -> VERIFIED