Flag <select> not disabled even though user can't request or change flag

RESOLVED FIXED in Bugzilla 3.0

Status

()

defect
--
minor
RESOLVED FIXED
11 years ago
7 years ago

People

(Reporter: reed, Assigned: reed)

Tracking

3.0.3
Bugzilla 3.0
Bug Flags:
approval +
approval3.0 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch patch - v1 (obsolete) — Splinter Review
There are three different possible <select>s in template/en/default/flag/list.html.tmpl that can be used for flags. All but one has a check that makes the <select> disabled if the user can't request it. Not sure why that one was missed, but it should be fixed.
Attachment #321044 - Flags: review?(LpSolit)
I see no reason to mark it as disabled, even if you cannot change it. The reason this one is not disabled is because this flag already exists while in the other two cases, the flag doesn't exist yet. In the case described in this bug, the user would see a flag with a single option, which is the one already selected. I'm fine with that.
Posted patch patch - v2Splinter Review
Change the other two <select>s instead rather than modifying the first one incorrectly.
Attachment #321044 - Attachment is obsolete: true
Attachment #321092 - Flags: review?(LpSolit)
Attachment #321044 - Flags: review?(LpSolit)
Comment on attachment 321092 [details] [diff] [review]
patch - v2

Tested on both 3.0.4 and 3.1.4. r=LpSolit
Attachment #321092 - Flags: review?(LpSolit) → review+
Severity: normal → minor
Flags: approval3.0+
Flags: approval+
Target Milestone: --- → Bugzilla 3.0
tip:

Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.32; previous revision: 1.31
done

BUGZILLA-3_0-BRANCH:

Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.27.2.3; previous revision: 1.27.2.2
done
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 321092 [details] [diff] [review]
patch - v2

&gt
Comment on attachment 321092 [details] [diff] [review]
patch - v2

&gt
Comment on attachment 321092 [details] [diff] [review]
patch - v2

&gt
Comment on attachment 321044 [details] [diff] [review]
patch - v1

&gt
Comment on attachment 321044 [details] [diff] [review]
patch - v1

&gt
Comment on attachment 321044 [details] [diff] [review]
patch - v1

&gt
You need to log in before you can comment on or make changes to this bug.