Last Comment Bug 433851 - Flag <select> not disabled even though user can't request or change flag
: Flag <select> not disabled even though user can't request or change flag
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Attachments & Requests (show other bugs)
: 3.0.3
: All All
: -- minor (vote)
: Bugzilla 3.0
Assigned To: Reed Loden [:reed] (use needinfo?)
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-15 03:01 PDT by Reed Loden [:reed] (use needinfo?)
Modified: 2013-02-19 06:40 PST (History)
2 users (show)
LpSolit: approval+
LpSolit: approval3.0+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch - v1 (1.25 KB, patch)
2008-05-15 03:01 PDT, Reed Loden [:reed] (use needinfo?)
no flags Details | Diff | Review
patch - v2 (2.29 KB, patch)
2008-05-15 09:22 PDT, Reed Loden [:reed] (use needinfo?)
LpSolit: review+
Details | Diff | Review

Description Reed Loden [:reed] (use needinfo?) 2008-05-15 03:01:08 PDT
Created attachment 321044 [details] [diff] [review]
patch - v1

There are three different possible <select>s in template/en/default/flag/list.html.tmpl that can be used for flags. All but one has a check that makes the <select> disabled if the user can't request it. Not sure why that one was missed, but it should be fixed.
Comment 1 Frédéric Buclin 2008-05-15 03:53:12 PDT
I see no reason to mark it as disabled, even if you cannot change it. The reason this one is not disabled is because this flag already exists while in the other two cases, the flag doesn't exist yet. In the case described in this bug, the user would see a flag with a single option, which is the one already selected. I'm fine with that.
Comment 2 Reed Loden [:reed] (use needinfo?) 2008-05-15 09:22:12 PDT
Created attachment 321092 [details] [diff] [review]
patch - v2

Change the other two <select>s instead rather than modifying the first one incorrectly.
Comment 3 Frédéric Buclin 2008-05-15 09:43:40 PDT
Comment on attachment 321092 [details] [diff] [review]
patch - v2

Tested on both 3.0.4 and 3.1.4. r=LpSolit
Comment 4 Reed Loden [:reed] (use needinfo?) 2008-05-15 10:39:18 PDT
tip:

Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.32; previous revision: 1.31
done

BUGZILLA-3_0-BRANCH:

Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.27.2.3; previous revision: 1.27.2.2
done
Comment 5 sudhanshu 2013-02-19 06:40:46 PST
Comment on attachment 321092 [details] [diff] [review]
patch - v2

&gt
Comment 6 sudhanshu 2013-02-19 06:40:46 PST
Comment on attachment 321092 [details] [diff] [review]
patch - v2

&gt
Comment 7 sudhanshu 2013-02-19 06:40:46 PST
Comment on attachment 321092 [details] [diff] [review]
patch - v2

&gt
Comment 8 sudhanshu 2013-02-19 06:40:48 PST
Comment on attachment 321044 [details] [diff] [review]
patch - v1

&gt
Comment 9 sudhanshu 2013-02-19 06:40:48 PST
Comment on attachment 321044 [details] [diff] [review]
patch - v1

&gt
Comment 10 sudhanshu 2013-02-19 06:40:48 PST
Comment on attachment 321044 [details] [diff] [review]
patch - v1

&gt

Note You need to log in before you can comment on or make changes to this bug.