433873 - mozilla-central win32 builds not building with PGO

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[(not currently active) Ted Mielczarek]

This is kind of important. Should be easy to make it happen, just need to ensure we have the profiling script bit in the mozconfig, and `make -f client.mk profiledbuild` instead of build.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: enable pgo for windows non-debug builds

I've got this patch testing on the Mozilla2 staging Buildbot right now. It's gotten past profileserver.py and is finishing up the second pass. I'm pretty sure it'll go green so I may as well put this up now.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 321110 [details] [diff] [review]
enable pgo for windows non-debug builds

Might be a little nicer to have it check |if 'profiled_build' in pf and pf['profiled_build']|, so you don't have to explicitly specify all the platforms that don't want this, but I didn't look at your prevailing style in the master.cfg, so whichever fits better.

Comment 3

[[e-mail] (:bhearsum)]

I think I'd rather have the verbosity in the config block -- I'll be factoring that part out to an external file soon (hopefully). I do fear that the conditionals in this file are getting a bit much, though.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: [checked in] same as before, unbitrotted + longer timeout

PGO worked fine after bumping up the timeout. This patch makes that adjustment.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 321146 [details] [diff] [review]
[checked in] same as before, unbitrotted + longer timeout

Landed in changeset:   64:202f1fabd32d

Comment 6

[[e-mail] (:bhearsum)]

Updated the buildmaster.

Comment 7

[[e-mail] (:bhearsum)]

Hm, do we want PGO on actionmonkey builds, too?

Comment 8

[(not currently active) Ted Mielczarek]

You'd have to ask bsmedberg or jorendorff. Win32 actionmonkey builds are still burning anyway, so it's sort of irrelevant right now. :)

Comment 9

[Jason Orendorff [:jorendorff]]

(In reply to comment #7)
> Hm, do we want PGO on actionmonkey builds, too?

Sure do, but... what Ted said.