Closed Bug 433873 Opened 16 years ago Closed 16 years ago

mozilla-central win32 builds not building with PGO

Categories

(Release Engineering :: General, defect, P2)

x86
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: bhearsum)

References

Details

Attachments

(1 file, 1 obsolete file)

This is kind of important. Should be easy to make it happen, just need to ensure we have the profiling script bit in the mozconfig, and `make -f client.mk profiledbuild` instead of build.
Assignee: nobody → bhearsum
Priority: -- → P2
I've got this patch testing on the Mozilla2 staging Buildbot right now. It's gotten past profileserver.py and is finishing up the second pass. I'm pretty sure it'll go green so I may as well put this up now.
Attachment #321110 - Flags: review?(ted.mielczarek)
Comment on attachment 321110 [details] [diff] [review]
enable pgo for windows non-debug builds

Might be a little nicer to have it check |if 'profiled_build' in pf and pf['profiled_build']|, so you don't have to explicitly specify all the platforms that don't want this, but I didn't look at your prevailing style in the master.cfg, so whichever fits better.
Attachment #321110 - Flags: review?(ted.mielczarek) → review+
I think I'd rather have the verbosity in the config block -- I'll be factoring that part out to an external file soon (hopefully). I do fear that the conditionals in this file are getting a bit much, though.
PGO worked fine after bumping up the timeout. This patch makes that adjustment.
Status: NEW → ASSIGNED
Whiteboard: [landing on may 16]
Comment on attachment 321146 [details] [diff] [review]
[checked in] same as before, unbitrotted + longer timeout

Landed in changeset:   64:202f1fabd32d
Attachment #321146 - Attachment description: same as before, unbitrotted + longer timeout → [checked in] same as before, unbitrotted + longer timeout
Attachment #321110 - Attachment is obsolete: true
Updated the buildmaster.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [landing on may 16]
Hm, do we want PGO on actionmonkey builds, too?
You'd have to ask bsmedberg or jorendorff. Win32 actionmonkey builds are still burning anyway, so it's sort of irrelevant right now. :)
(In reply to comment #7)
> Hm, do we want PGO on actionmonkey builds, too?

Sure do, but... what Ted said.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: