433947 - Move goToDateDialog.js/xul from resources/content to sunbird/base/content

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Martin Schröder [:mschroeder]]

Comment 1

[Stefan Sitter [:ssitter]]

I thought there was a request to offer the same feature in Lightning. In that case the files probably should not be moved to sunbird folder.

Comment 2

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

(In reply to comment #1)
> I thought there was a request to offer the same feature in Lightning. In that
> case the files probably should not be moved to sunbird folder.

I move the file to the sunbird directory, a move to base should be no problem if it is needed for an RFE in the future.

I eliminated the js file because imo it was overhead that can live in the xul file. In addition I removed some unneeded, old comments and the unused variable this.availableViews from calendarWindow.js... the file will be finally removed in bug 329582.

Comment 3

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 321643 [details] [diff] [review]
Patch v1

>+   - The Initial Developer of the Original Code is
>+   - OEone Corporation.
>+   - Portions created by the Initial Developer are Copyright (C) 2001
Indent OEone by two spaces

>+<!-- When opening calendar-gotodate-dialog.xul, you can supply two arguments:
>+     * callback - function that should be called with datepicker value as argument
>+                  when clicking OK button
>+     * date (optional) - initially selected date in datepicker -->
Please try to make clear that its not multiple arguments, but one object argument that contains the named keys.

r=philipp

Comment 4

[Martin Schröder [:mschroeder]]

(In reply to comment #3)
> (From update of attachment 321643 [details] [diff] [review])
> >+   - The Initial Developer of the Original Code is
> >+   - OEone Corporation.
> >+   - Portions created by the Initial Developer are Copyright (C) 2001
> Indent OEone by two spaces

Nope, see examples on official boilerplate page (http://www.mozilla.org/MPL/boilerplate-1.1/).

Comment 5

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Oh, you are right. I had the feeling we did all calendar files with two space indent, but that isn't the case either. I personally like indenting there, but I don't mind if you don't.

Comment 6

[Martin Schröder [:mschroeder]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 7

[Andreas Treumann]

Checked on mxr.mozills.com -> VERIFIED