Closed
Bug 434008
Opened 17 years ago
Closed 16 years ago
Readonly custom field texts appear too small
Categories
(Bugzilla :: User Interface, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: guy.pyrzak, Assigned: guy.pyrzak)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
67.06 KB,
image/png
|
Details | |
476 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
On edit bug custom fields appear with font-size:small, this makes the text hard to see.
Assignee | ||
Comment 1•17 years ago
|
||
Assignee: ui → guy.pyrzak
Status: NEW → ASSIGNED
Attachment #321211 -
Flags: review?(mkanat)
Attachment #321211 -
Flags: review?(LpSolit)
Comment 2•17 years ago
|
||
(In reply to comment #0) > On edit bug custom fields appear with font-size:small, this makes the text hard > to see. Really? I don't see this. Do you have a screenshot and could you point me to the place which makes the text to be smaller?
Assignee | ||
Comment 3•17 years ago
|
||
Assignee | ||
Comment 4•17 years ago
|
||
regression caused by bug 357315. is it ok just to remove that class? 104 <div class="uneditable_textarea">[% value FILTER wrap_comment(60) 105 FILTER html %]</div>
Depends on: 357315
Keywords: regression
Comment 5•17 years ago
|
||
It's rather a regression due to bug 388723.
Comment 6•17 years ago
|
||
Comment on attachment 321211 [details] [diff] [review] Patch v1 As discussed on AIM, I don't think this is the right fix. The font being different and of a different size but be fixed at its root.
Attachment #321211 -
Flags: review?(LpSolit)
Comment 7•17 years ago
|
||
Comment on attachment 321211 [details] [diff] [review] Patch v1 Is this a problem with .uneditable_textarea, or with .field_value?
Comment 8•17 years ago
|
||
Comment on attachment 321211 [details] [diff] [review] Patch v1 If this is a problem with .uneditable_textarea, it should just be fixed there.
Attachment #321211 -
Flags: review?(mkanat) → review-
Comment 9•16 years ago
|
||
I hope this bug summary will better reflect what the problem is, i.e. that the text of custom fields displayed as readonly is too small, not the field itself (e.g. the width of text forms).
Summary: Custom fields appear too small → Readonly custom field texts appear too small
Updated•16 years ago
|
Severity: normal → minor
Updated•16 years ago
|
Flags: blocking3.2+
Comment 11•16 years ago
|
||
By looking at the uneditable_textarea class, it seems the problem is not font-size:small (which doesn't exist for this class), but rather because it has font-family:monospace. monospace can have a different font size than "normal" text, explaining the difference. Probably it's unappropriate to define font-family here, i.e. it should only be used by the bz_comment_text class.
Comment 12•16 years ago
|
||
pyrzak, to be sure: you only see this problem with readonly textarea, right? Or do you also see this problem with other readonly text fields? If it's only about textarea (which seems to be the case by looking at classes defined in CSS files), then the bug summary should be updated to reflect that (because it's currently confusing, and the checkin message will also be).
Assignee | ||
Comment 13•16 years ago
|
||
Um... i think this bug is fixed. can someone verify?
Assignee | ||
Comment 14•16 years ago
|
||
Attachment #321211 -
Attachment is obsolete: true
Attachment #341560 -
Flags: review?(mkanat)
Updated•16 years ago
|
Attachment #341560 -
Flags: review?(mkanat) → review+
Comment 15•16 years ago
|
||
Please add a space after the colon on checkin. (I've nitted that like a zillion times, now, BTW.)
Flags: approval3.2+
Flags: approval+
Assignee | ||
Comment 16•16 years ago
|
||
Checking in skins/standard/global.css; /cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v <-- global.css new revision: 1.53; previous revision: 1.52 done Checking in skins/standard/global.css; /cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v <-- global.css new revision: 1.47.2.5; previous revision: 1.47.2.4 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•