GTK treelines are drawn in random colour when no specific rule is given

RESOLVED FIXED

Status

()

Core
Widget: Gtk
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Karsten Düsterloh, Assigned: Karsten Düsterloh)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
When turning on treelines on Linux/GTK (running SeaMonkey/Thunderbird/Firefox under KDE), the treeline colour isn't stable when undefined (=when no other rule specifying a fixed value exists). On various startups I get seemingly random colours, including the tree background colour.

See also bug 430852 comment 63 and bug 118312 comment 64 and follow-ups.
(Assignee)

Comment 1

10 years ago
Created attachment 336114 [details] [diff] [review]
set actual value color when GetBorderColor does not

For Gnome(stripe), GetBorderColor says "use foreground color" and refuses to set the color - but the color variable is undefined so far and its value used then nonetheless...
This patch sets colors when GetBorderColor won't.
Assignee: nobody → mnyromyr
Attachment #336114 - Flags: superreview?
Attachment #336114 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #336114 - Flags: superreview?(roc)
Attachment #336114 - Flags: superreview?
Attachment #336114 - Flags: review?(roc)
Attachment #336114 - Flags: review?
Attachment #336114 - Flags: superreview?(roc)
Attachment #336114 - Flags: superreview+
Attachment #336114 - Flags: review?(roc)
Attachment #336114 - Flags: review+
Comment on attachment 336114 [details] [diff] [review]
set actual value color when GetBorderColor does not

Excellent, thanks!
(Assignee)

Comment 3

10 years ago
Landed on trunk, <http://hg.mozilla.org/mozilla-central/rev/ac165d7e8dd4>.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.