434096 - We should decrease the popup spam count when the popup is closed, not when it's GCed

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Boris Zbarsky [:bzbarsky]]

Right now, we decrease the popup spam count when:

1)  window.close() is called on a popup spam Window which is the only tab in its
    XULWindow.
2)  A popup spam Window is GCed.

In particular, this means that if the user closes the popup spam using the windowmanager decoration or if the popup spam is in a tab and is closed with window.close(), we won't decrement the counter until the now-closed window is GCed, which might be a while if the page is holding a ref to it.

I think it would make more sense to decrement the count when we get closed, if we can detect that...  For example, when do we get our docshell nulled out?

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.