434102 - Tree row styling: outline is far larger than border

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008051602 SeaMonkey/2.0a1pre

Styling tree rows: weird results with "outline" as compared to "border".

Reproducible: Always

Steps to Reproduce:
1. Copy the following into your userChrome.css for SeaMonkey (or, presumably, Thunderbird):

treechildren::-moz-tree-row(current)
  { outline:            1px dotted green        !important
  ;  border:            2px solid yellow           !important
  }

2. Restart the mailer.
3. Go to a folder or newsgroup with several messages
4. Make the List pane current
5. Hit Ctrl+Down and/or Ctrl+Up one or more times.

Actual results:
- The yellow rectangle ("border") surrounds the current line only;
- The green dotted rectangle ("outline") surrounds the block of all lines from the current message all the way down to the bottom of the pane.

Expected results:
The "border" and the "outline" should surround (at maybe a few pixels' distance) the same area, in this case the current line only.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Make outlines behave reasonably on XUL tree pseudo-elements again.

This was a regression from bug 133165 which I noticed while working on
bug 480888, but wished to fix in a separate patch (despite that it would
have been slightly easier to fix it in the same patch).

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also note that I believe this will change some actual rendering in the Firefox UI on Windows only, because when I was working on bug 480888, I had a try push with an assertion that I think fired only on Windows.  I expect it's some pretty obscure UI, though.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bcba561c4e53

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And marked the reftest as failing on Mac (where the text gets aligned differently between the border case and the outline case):
https://hg.mozilla.org/integration/mozilla-inbound/rev/772392d933ea

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bcba561c4e53
https://hg.mozilla.org/mozilla-central/rev/772392d933ea