434192 - Fails to build after make clean on architectures using .s files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Attachment: patch

The ALL_TRASH variable contains .s files corresponding to .o files ($(OBJS:.$(OBJ_SUFFIX)=.s)), but in some directories where there are .s source files, this means removing source files, which, in turn, leads to failure to build after make clean because of missing source files.

Attached patch fixes the issue.

Comment 2

[Mike Hommey [:glandium]]

Considering there is a patch here and not there, shouldn't the duplicate be reversed ?

Comment 3

[(not currently active) Ted Mielczarek]

Sorry, yeah, do whatever's easier for you.

Comment 6

[Ginn Chen]

The patch is never landed, right?

Comment 7

[Benjamin Smedberg]

Pushed to mozilla-central: https://hg.mozilla.org/mozilla-central/index.cgi/rev/5f9f6eb00601

Comment 8

[Samuel Sidler (old account; do not CC)]

r.mozley: There's no way this will block 1.9.0.16. When you nominate, please nominate with rationale. We might consider a patch for this, assuming someone asks for approval and tests said patch on a 1.9.0 tree.

Comment 9

[R P Mozley]

Sorry about that, I don't know the correct procedure to get this onto the 1.9.0 branch. The patch is already there and was written (I believe) for the 1.9.0 branch.

Comment 10

[Mike Hommey [:glandium]]

FYI, this patch has been in use in Debian since 1.9rc1.

Comment 11

[R P Mozley]

Attachment: 1.9.0 branch patch

Updated the patch for the 1.9.0 branch.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 414399 [details] [diff] [review]
1.9.0 branch patch

Approved for 1.9.0.16, a=dveditz for release-drivers

Comment 13

[Samuel Sidler (old account; do not CC)]

(dveditz meant 1.9.0.17 as indicated by the appropriate approval flag.)

Comment 14

[Reed Loden [:reed]]

Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.597; previous revision: 3.596
done