Closed
Bug 434291
Opened 17 years ago
Closed 17 years ago
fix calendar-ui-utils' addMenuItem
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.9
People
(Reporter: dbo, Assigned: dbo)
Details
Attachments
(1 file)
1.16 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
The passed over value is not set.
Assignee | ||
Comment 1•17 years ago
|
||
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #321468 -
Flags: review?(Berend.Cornelius)
Comment 2•17 years ago
|
||
Comment on attachment 321468 [details] [diff] [review]
fix
Interesting, http://developer.mozilla.org/en/docs/XUL:menuitem tells us that the value property is valid. While this workaround is valid, checking if this works on trunk and filing a core bug otherwise might be an option for the future, since setting the value property is a bit more compact.
r=philipp
Attachment #321468 -
Flags: review?(Berend.Cornelius) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
You need to log in
before you can comment on or make changes to this bug.
Description
•