Closed Bug 434291 Opened 15 years ago Closed 15 years ago

fix calendar-ui-utils' addMenuItem

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbo, Assigned: dbo)

Details

Attachments

(1 file)

The passed over value is not set.
Attached patch fixSplinter Review
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #321468 - Flags: review?(Berend.Cornelius)
Comment on attachment 321468 [details] [diff] [review]
fix

Interesting, http://developer.mozilla.org/en/docs/XUL:menuitem tells us that the value property is valid. While this workaround is valid, checking if this works on trunk and filing a core bug otherwise might be an option for the future, since setting the value property is a bit more compact.

r=philipp
Attachment #321468 - Flags: review?(Berend.Cornelius) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Checked via mxr.mozilla.org -> VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.