434397 - Duplicated code in |PR_snprintf()| and |PR_vsnprintf()|

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Serge Gautherie (:sgautherie)]

From bug 186547 comment 5:
{{
Serge Gautherie   2003-12-19 17:53:58 PDT

Is the |if ((PRInt32)outlen == 0) {| block needed in |PR_snprintf()|,
since it is already in |PR_vsnprintf()| ?
}}

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Serge, By how many bytes does the removal of this duplicated test reduce
the size of an optimized build?

Comment 2

[Serge Gautherie (:sgautherie)]

No idea, probably very few.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <prprf.c> [Checkin: Comment 6]

NB:
I noticed that this file is full of tabs.
Would you accept a separate tabs->spaces cleanup patch ?

Comment 4

[Wan-Teh Chang]

Comment on attachment 321586 [details] [diff] [review]
(Av1) <prprf.c>
[Checkin: Comment 6]

r=wtc.  Thanks for the patch.

Don't fix the tabs unless they mess up the indentation.
I often need to read diffs when fixing NSPR bugs.  Unnecessary
whitespace changes will add noise to the diffs.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Don't fix the tabs unless they mess up the indentation.

I prefer to do it all/none. I'll leave it as is then.

Comment 6

[Wan-Teh Chang]

I checked in the patch on the NSPR trunk (NSPR 4.7.2).

Checking in prprf.c;
/cvsroot/mozilla/nsprpub/pr/src/io/prprf.c,v  <--  prprf.c
new revision: 3.20; previous revision: 3.19
done