Closed Bug 434696 Opened 13 years ago Closed 13 years ago

Polish dictionary not available after updating from Fx3b5 to RC1

Categories

(Toolkit :: Application Update, defect, P2)

1.9.0 Branch
x86
Windows XP
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: piecu, Assigned: nthomas)

Details

(Whiteboard: [RC2+])

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9pre; .NET CLR 3.0; ffco7) Gecko/2008041306 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9) Gecko/2008051206 Firefox/3.0

I had Firefox 3 b5 installed with polish dictionary (installed by default). After automatic update to RC1 the dictionary has gone.

There is no such a problem on a full installation of Firefox 3 RC1.

I have reproduced the problem on a 3 computers, including one with a clean profile.

Reproducible: Always

Steps to Reproduce:
1. Download polish version of Fx3b5 and install it. Ensure that there is a polish dictionary.
2. Check for updates and allow to install RC1.
3. See that there is no polish dictionary installed.
Confirmed this affects both Windows and Mac.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 3.0 Branch
This is fallout from
* the Polish dictionary files for 2.0.0.x having names PL.aff & PL.dic
* the equivalent files for 3.0.y being renamed to pl.aff & pl.dic when the localizers picked up the change from MySpell to Hunspell
* wanting to remove the old (uppercase) files when doing a major update from 2.0.0.x to 3.0.y (bug 394046), so we added
   http://mxr.mozilla.org/seamonkey/source/browser/installer/removed-files.in#615
* the same file being used for 3.0 -> 3.0 updates
* Mac and Windows not being case sensitive for filenames, so the updater removes the lowercase files when we want to remove the uppercase ones

Really we just want to remove the uppercase files on Linux for a major update, on Mac and Windows they'll just be replaced. 
Move the files inside a Linux only ifdef.
Assignee: nobody → nrthomas
Status: NEW → ASSIGNED
Attachment #321749 - Flags: review?(ted.mielczarek)
I think we should consider taking a fix for this if we do a 3.0 RC2. Alas, it's too late for people who updated 3.0 beta's to RC1.
Flags: blocking-firefox3?
Priority: -- → P2
Whiteboard: [RC2?]
This should be in the next update, regardless of whether its RC2 or 3.0.1.  It doesn't really matter which it is as long as its in that update.
Flags: blocking1.9.0.1+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Whiteboard: [RC2?] → [needs to be in RC2 if it happens, otherwise 3.0.1]
Attachment #321749 - Flags: review?(ted.mielczarek) → review+
Attachment #321749 - Flags: approval1.9?
Should this be on the [RC2?][RC2+] list now?
Some statistics, before you take the decision.

Now 0.62% of Internet users in Poland use Firefox 3.0:
http://www.en.ranking.pl/index.php?page=Ranks:RanksPage&stat=22|OW&details=1
We have about 17,000,000 Internet users in Poland so it means that Firefox 3.0 has about 100,000 users in Poland.
(In reply to comment #4)
> I think we should consider taking a fix for this if we do a 3.0 RC2. Alas, it's
> too late for people who updated 3.0 beta's to RC1.
> 

I'm not sure we'd loose our testers on this forever, if we added a change to both the aff and the dic, it'd be part of the update, the incremental update would fail, and the full update would then work. At least I'd expect that.
Does anybody have a trivial and safe patch for the aff and dic files of the Polish dictionary that we could include into RC2, if we wanted?
I could update it to a newer daily build <http://www.sjp.pl/slownik/ort/>. 

The patch would probably look scary, as the development of that dictionary is very lively, but in fact should be really safe.
Back to the nomination queue for RC2, as the current whiteboard doesn't get picked up.

Attachment 321749 [details] [diff] makes the removal of pl.aff and pl.dic platform dependent. This change will keep Firefox 3 from breaking new users migrating from fx2 to 3 for Polish. For risk assessment, see comment 2.

The discussion about an additional change to the dictinaries we ship right now is merely to make those part of the upgrade for existing users on RC1 and before, and is merely a cookie for our testing community, it is not essential to actually fixing this bug.
Whiteboard: [needs to be in RC2 if it happens, otherwise 3.0.1] → [RC2?]
(In reply to comment #11)
> Attachment 321749 [details] [diff] makes the removal of pl.aff and pl.dic platform dependent.
> This change will keep Firefox 3 from breaking new users migrating from fx2 to 3
> for Polish. For risk assessment, see comment 2.

It also prevents people who used the Polish 3.0 RC1 installer/dmg from losing their dictionary when updating to 3.0 RC2/3.0.1. (removed-files.in is preprocessed and included in the complete mar when compiling a build. We use those files for the current release-in-progress, and when setting up the major update. The win32 installer also uses removed-files.in, that's what Axel is talking about.)

I agree with Axel that updating the Polish dict is "nice to have" (for people who updated to 3.0 RC1 and lost it already).
 
Comment on attachment 321749 [details] [diff] [review]
[checked in] Fix up removed-files.in

a=beltzner, land on cvsroot asap
Attachment #321749 - Flags: approval1.9? → approval1.9+
Comment on attachment 321749 [details] [diff] [review]
[checked in] Fix up removed-files.in

Checking in removed-files.in;
/cvsroot/mozilla/browser/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.50; previous revision: 1.49
done
Attachment #321749 - Attachment description: Fix up removed-files.in → [checked in] Fix up removed-files.in
Fixed for 3.0 RC2/3.0.1, whatever shall be. 
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [RC2?] → [RC2+]
Also adds an empty line at the end of the .aff file, so that it differs from the old one.
Attachment #322671 - Flags: review?(l10n)
Attachment #322671 - Attachment is patch: true
Attachment #322671 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 322671 [details] [diff] [review]
Update the dictionary to the latest build

Cancelling the review request, can we get a follow up bug for that? That's going to make it easier to track what's fixed and what's not. Thanks.
Attachment #322671 - Flags: review?(l10n)
Ok, filed bug 435925 for this.
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008053008 Firefox/3.0
Status: RESOLVED → VERIFIED
Flags: blocking1.9.0.1+
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.