434739 - Add ac_add_options --enable-logrefcnt to moz2 testing boxes

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Jeff Walden [:Waldo]]

This is necessary for the leak testing runtests.py does to work.  1.9 tinderboxen already had this, but it seems it didn't translate over when the Moz2 work was being done.

Comment 1

[Jeff Walden [:Waldo]]

Probably also a good idea to add the location of each mozconfig in the tree in a comment in each mozconfig, as 1.9 tinderbox mozconfigs do, while you're editing the file.

Comment 2

[[e-mail] (:bhearsum)]

Do we need this for the existing debug+leak machines? (ie, mozilla-central-linux-debug, which doesn't run unit tests).

The existing mozconfigs for these are here: http://hg.mozilla.org/build/buildbot-configs/?file/tip/mozilla2/linux-debug/mozconfig (and in the other *-debug directories).

Comment 3

[Jeff Walden [:Waldo]]

It's only necessary for optimized builds, because debug implies logrefcnt.  Beyond that, tho, I don't think it matters anyway; this request is specifically so the unittest boxes can do leak detection, and for anything else (in particular the perf boxes) logrefcnt would just slow them down (not much, but some -- I'd bet it'd be noticeable on a perf graph).

Comment 4

[Rob Campbell [:rc] (:robcee)]

Jeff: this is a lot of bugmail for someone supposedly in appalachia-land. ;)

Ben: This is just for the opt-build, unittest machines as Jeff says. I'll add this up.

Comment 5

[Jeff Walden [:Waldo]]

Not til June, sadly.  :-)

Comment 6

[Rob Campbell [:rc] (:robcee)]

Attachment: mozconfig updates with mercurial support

I've morphed this patch into more than just adding logrefcnt to the mozconfigs and including their location. I added mercurial support for mozconfig checkout to the master.cfg and did a bit of master.cfg cleanup.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 321792 [details] [diff] [review]
mozconfig updates with mercurial support

Looks fine to me.

Comment 8

[Rob Campbell [:rc] (:robcee)]

committed and pushed.

http://hg.mozilla.org/build/buildbot-configs/index.cgi/rev/d49534439c4c

running on master.

Comment 9

[Rob Campbell [:rc] (:robcee)]

the mercurial update portion of those steps caused a full clobber on the slave/build directory first. We'll need to prevent that from happening again before we can do this.

Comment 10

[Rob Campbell [:rc] (:robcee)]

Attachment: [checked in] mozconfig updates with mercurial support 2

fixes clobber problem by adding a workdir to mercurial step.

Comment 11

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 321974 [details] [diff] [review]
[checked in] mozconfig updates with mercurial support 2

running ssh hg.mozilla.org "hg -R build/buildbot-configs serve --stdio"
remote: Could not chdir to home directory : No such file or directory
pushing to ssh://hg.mozilla.org/build/buildbot-configs
searching for changes
note: unsynced remote changes!
1 changesets found
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files

Comment 12

[Rob Campbell [:rc] (:robcee)]

this doesn't work either. Getting:

Traceback (most recent call last):
  File "/tools/buildbot-trunk/lib/python2.5/site-packages/buildbot/process/buildstep.py", line 677, in startStep
    d.addCallback(self._startStep_2)
  File "/tools/twisted-8.0.1/lib/python2.5/site-packages/twisted/internet/defer.py", line 194, in addCallback
    callbackKeywords=kw)
  File "/tools/twisted-8.0.1/lib/python2.5/site-packages/twisted/internet/defer.py", line 185, in addCallbacks
    self._runCallbacks()
  File "/tools/twisted-8.0.1/lib/python2.5/site-packages/twisted/internet/defer.py", line 323, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
--- <exception caught here> ---
  File "/tools/buildbot-trunk/lib/python2.5/site-packages/buildbot/process/buildstep.py", line 700, in _startStep_2
    skip = self.start()
  File "/tools/buildbot-trunk/lib/python2.5/site-packages/buildbot/steps/source.py", line 184, in start
    self.startVC(branch, revision, patch)
  File "/tools/buildbot-trunk/lib/python2.5/site-packages/buildbot/steps/source.py", line 886, in startVC
    assert not branch # we need baseURL= to use branches
exceptions.AssertionError: 


Tried setting a baseURL and defaultBranch without success. This looks like a buildbot bug to me.

Comment 13

[Rob Campbell [:rc] (:robcee)]

Attachment: logrefcnt moz2 patch in cvs

moving mozconfigs to cvs since we can't checkout from mercurial in a sensible way.

Comment 14

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 321984 [details] [diff] [review]
logrefcnt moz2 patch in cvs

I don't know how else to do this for now and don't want to hold this up any longer.

Comment 15

[Rob Campbell [:rc] (:robcee)]

Attachment: reverting changes to master.cfg

Comment 16

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 321984 [details] [diff] [review]
logrefcnt moz2 patch in cvs

cvs commit: Examining .
Checking in mozconfig-firefox-darwin;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin,v  <--  mozconfig-firefox-darwin
new revision: 1.3; previous revision: 1.2
done
Checking in mozconfig-firefox-linux;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-linux,v  <--  mozconfig-firefox-linux
new revision: 1.2; previous revision: 1.1
done
Checking in mozconfig-firefox-win2k3;
/cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v  <--  mozconfig-firefox-win2k3
new revision: 1.5; previous revision: 1.4
done

Comment 17

[[e-mail] (:bhearsum)]

Comment on attachment 321984 [details] [diff] [review]
logrefcnt moz2 patch in cvs

>Index: mozconfig-firefox-darwin
>===================================================================
>RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin,v
>retrieving revision 1.2
>diff -u -8 -p -r1.2 mozconfig-firefox-darwin
>--- mozconfig-firefox-darwin	21 Apr 2008 17:43:01 -0000	1.2
>+++ mozconfig-firefox-darwin	21 May 2008 18:46:12 -0000
>@@ -1,6 +1,10 @@
>+# mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-darwin
>+
> ac_add_options --enable-application=browser
> mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
> ac_add_options --disable-debug
> ac_add_options --enable-tests
> mk_add_options RUN_AUTOCONF_LOCALLY=1
> mk_add_options AUTOCONF=/opt/local/bin/autoconf213
>+ac_add_options --enable-optimize
>+ac_add_options --enable-logrefcnt
>\ No newline at end of file
>Index: mozconfig-firefox-linux
>===================================================================
>RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-linux,v
>retrieving revision 1.1
>diff -u -8 -p -r1.1 mozconfig-firefox-linux
>--- mozconfig-firefox-linux	18 Apr 2008 18:23:39 -0000	1.1
>+++ mozconfig-firefox-linux	21 May 2008 18:46:12 -0000
>@@ -1,8 +1,11 @@
>+# mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-linux
>+
> ac_add_options --enable-application=browser
> mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
>-ac_add_options --enable-optimize="-Os"
> ac_add_options --disable-debug
> ac_add_options --enable-tests
>+ac_add_options --enable-optimize
>+ac_add_options --enable-logrefcnt
> 
> CC=/tools/gcc/bin/gcc
> CXX=/tools/gcc/bin/g++
>Index: mozconfig-firefox-win2k3
>===================================================================
>RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3,v
>retrieving revision 1.4
>diff -u -8 -p -r1.4 mozconfig-firefox-win2k3
>--- mozconfig-firefox-win2k3	14 May 2008 17:43:42 -0000	1.4
>+++ mozconfig-firefox-win2k3	21 May 2008 18:46:12 -0000
>@@ -1,13 +1,14 @@
>-#
>+# mozilla/tools/buildbot-configs/testing/moz2unit/mozconfig-firefox-win2k3
> ## hostname: qm-win2k3-moz2-01
> #
> 
> # . $topsrcdir/browser/config/mozconfig
> 
> mk_add_options MOZ_CO_PROJECT=browser
> mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
> 
> ac_add_options --enable-application=browser
>-ac_add_options --enable-optimize
> ac_add_options --disable-debug
> ac_add_options --enable-tests
>+ac_add_options --enable-optimize
>+ac_add_options --enable-logrefcnt

Comment 18

[Rob Campbell [:rc] (:robcee)]

one last thing here. It looks like the windows boxes aren't finishing the mochitest run or the leak log is not getting flushed to stdout. Jeff, can you take a look at the results on qm-win2k3-moz2-01?

Comment 19

[Rob Campbell [:rc] (:robcee)]

whups, did all this before I got through my bugmail. Looks like you're already tracking this in bug 435138, so I will close this out and mark it fixed.