Closed
Bug 434746
Opened 17 years ago
Closed 17 years ago
Make mailnews/addrbook compile with frozen linkage on mac
Categories
(MailNews Core :: Address Book, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
|
2.84 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
|
687 bytes,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Just a few changes to help with the compilation process with frozen linkage.
Attachment #321765 -
Flags: superreview?(bienvenu)
Attachment #321765 -
Flags: review?(bienvenu)
|
||
Updated•17 years ago
|
Attachment #321765 -
Flags: superreview?(bienvenu)
Attachment #321765 -
Flags: superreview+
Attachment #321765 -
Flags: review?(bienvenu)
Attachment #321765 -
Flags: review+
|
Assignee | |
Comment 1•17 years ago
|
||
On check in of the previous patch it complained about EqualsLiteral(const char* const&) not being a valid function. So I've reworked it to plain equals. I believe case sensitive is not an issue here as EqualsASCII did that as well. The interface still seems to work fine for me.
Attachment #321911 -
Flags: superreview?(bienvenu)
Attachment #321911 -
Flags: review?(bienvenu)
|
|
||
Updated•17 years ago
|
Attachment #321911 -
Flags: superreview?(bienvenu)
Attachment #321911 -
Flags: superreview+
Attachment #321911 -
Flags: review?(bienvenu)
Attachment #321911 -
Flags: review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Both patches checked in -> fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9
|
||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•