Closed
Bug 434860
Opened 16 years ago
Closed 16 years ago
Coverity 1150 - dead code in ocsp_CreateCertID
Categories
(NSS :: Libraries, defect, P4)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.1
People
(Reporter: nelson, Assigned: julien.pierre)
Details
Attachments
(1 file)
|
743 bytes,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
Found by Coverity on its last Firefox 3 test run, 2007-May-14
CID 1150
In function ocsp_CreateCertID, variable tempItem is initialized to NULL
1593 SECItem *tempItem = NULL;
and then is not touched again until label loser, where it is checked for NULL.
1665 if (tempItem != NULL) {
1666 SECITEM_FreeItem(tempItem, PR_TRUE);
1667 }
That condition can never be true. It's dead code. All the lines shown
above should be removed.
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → julien.pierre.boogz
|
|
Assignee | |
Updated•16 years ago
|
Priority: -- → P4
Target Milestone: --- → 3.12.1
|
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #321832 -
Flags: review?(nelson)
|
Reporter | |
Comment 2•16 years ago
|
||
Comment on attachment 321832 [details] [diff] [review]
Remove dead code
r+
Attachment #321832 -
Flags: review?(nelson) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Thanks for the review, Nelson.
Checking in ocsp.c;
/cvsroot/mozilla/security/nss/lib/certhigh/ocsp.c,v <-- ocsp.c
new revision: 1.51; previous revision: 1.50
done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•