434985 - Remove unused entities and properties

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

We do have a few unused entities and properties lying around. I used a slightly modified version of the script noted in the URL field and ran it on our source.

Note that script has some false entries! While I'm pretty sure that all entities were found correctly, this is not the case for properties, see the following example:

calGetString("repeatDetailsDay" + day_of_week(byday[0]))

repeatDetailsDay1 to repeatDetailsDay8 were "not found", but thats quite obvious given the above example.

It might be a good idea to keep some of these entities around, but I guess thats open for discussion.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Unused entities

Comment 2

[Simon Paquet [:sipaq]]

Attachment: Patch (part 1 - removal of entities in .dtd files) [checked in]

This patch covers all the unused entities in .dtd files. 

It matches with Philipp's list with the exception of the "percnt" entity in calendar.dtd (which isn't unused) and the spellcheck entities in sun-calendar-event-dialog.dtd (which will probably be needed later on).

I checked the unused status of every entity via mxr.mozilla.org. Thanks for the initial list, Philipp. Localizers will love this.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 322082 [details] [diff] [review]
Patch (part 1 - removal of entities in .dtd files) [checked in]

>-<!ENTITY calendar.context.modifyevent.label           "Edit Selected Event…">
>-<!ENTITY calendar.context.modifyevent.accesskey       "E">
>-<!ENTITY calendar.context.deleteevent.label           "Delete Selected Event">
>-<!ENTITY calendar.context.deleteevent.accesskey       "l">
>-<!ENTITY calendar.context.selectall.label             "Select All">
>-<!ENTITY calendar.context.selectall.accesskey         "A">

These were removed from the context menus, I believe. We might need them again in bug 340025. I guess we can remove them here and then possibly add again, localizers might find that annoying though. What do you think?


r=philipp

Comment 4

[Simon Paquet [:sipaq]]

I don't think that the "modifyevent" and "deleteevent" strings will stay exactly the same, so I will remove them. I will leave the "selectall" strings in, though.

Comment 5

[Stefan Sitter [:ssitter]]

Patch also removes strings that were added in preparation of upcoming features, e.g. the strings added with Bug 412800.

Comment 6

[Simon Paquet [:sipaq]]

Checked in the dtd patch into HEAD and MOZILLA_1_8_BRANCH. I re-added the two strings added in bug 412800.

Comment 7

[Simon Paquet [:sipaq]]

Attachment: Patch (part 2 - removal of entities in .properties files)

This patch covers the unused entities in .properties files.

I removed all the entities listed in Philipp's file after checking their unused status via mxr.mozilla.org with the exception of:

- The "updatesItem_*" entities in calendar.properties are used in the 
  sbUpdateItem() function of applicationUtil.js
- all entities in dateFormat.properties are in use
- all entities in sun-calendar-event-dialog.properties are in use

Comment 8

[Stefan Sitter [:ssitter]]

Comment on attachment 322183 [details] [diff] [review]
Patch (part 2 - removal of entities in .properties files)

vendorShortName seems to be used in the updater:
http://mxr.mozilla.org/mozilla1.8/search?string=vendorShortName

Comment 9

[Simon Paquet [:sipaq]]

Attachment: Patch (part 2 - removal of entities in .properties files) - v2 [checked in]

New patch without vendorShortName removed per ssitter's comment.

Comment 10

[Simon Paquet [:sipaq]]

Comment on attachment 322195 [details] [diff] [review]
Patch (part 2 - removal of entities in .properties files) - v2 [checked in]

Moving review request over to Berend, because Philipp is busy.

Comment 11

[Berend Cornelius]

Comment on attachment 322195 [details] [diff] [review]
Patch (part 2 - removal of entities in .properties files) - v2 [checked in]

patch looks good. r=berend

Comment 12

[Simon Paquet [:sipaq]]

2nd patch (properties part) checked in on HEAD and MOZILLA_1_8_BRANCH.