434989 - patch for FreeBSD 8-current (and after 7.0)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[okazaki]

User-Agent:       Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8.1.14) Gecko/20080423 Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8.1.14) Gecko/20080423 Firefox/2.0.0.14

1. Since FreeBSD has no /usr/bin/objformat after 7.0-RELEASE,
   $MOZ_OBJFORMAT is selected with "aout".
2. support amd64.


Reproducible: Always

Comment 1

[okazaki]

Attachment: patch for build

Comment 2

[okazaki]

Attachment: patch ver.2

fix patch for security/coreconf/FreeBSD.mk.

Comment 3

[Makoto Kato [:m_kato]]

Okazaki-san, could you split bug into NSPR, NSS and mozilla?

Also, you should not attach diff of "configure" because some configure files are generated automatelly.

Comment 4

[okazaki]

Attachment: patch-for NSS

extract NSS patch from ver.2

Comment 5

[okazaki]

Attachment: patch for nspr

Comment 6

[okazaki]

Attachment: patch for xpcom

Comment 7

[okazaki]

Attachment: patch for mozilla

Comment 8

[okazaki]

Attachment: patch for mozilla v2

fogot to delete diff for "configure"

Comment 9

[okazaki]

Attachment: patch for nspr v2

fogot to delete diff for "configure"

Comment 10

[Makoto Kato [:m_kato]]

Okazaki-san, other code for freebsd/elf is checked in as bug 436806.  Could you test it? 

Comment 11

[okazaki]

I can't test it since I can't get patched version from cvs,
but bug 436806's patch seems fine for me.

Comment 12

[okazaki]

I patched by hand and tested bug 43806's patch,
FreeBSD/amd64 needs one more patch
 for  /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in.

Comment 13

[okazaki]

Attachment: patch for xpcom(amd64)

Comment 14

[Makoto Kato [:m_kato]]

(In reply to comment #12)
> I patched by hand and tested bug 43806's patch,
> FreeBSD/amd64 needs one more patch
>  for  /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in.
> 

Okazaki-san,
Although this patch is for *BSD, does it works on other BSD such as NetBSD/amd64 and Darwin/amd64??

Comment 15

[okazaki]

I think they will work, but I didn't check it.
NetBSD's pksrc patch(pkgsrc/www/firefox3/patches/patch-ac) is 
also use xptcinvoke_x86_64_linux.cpp and xptcstubs_x86_64_linux.cpp 
for x86_64, so NetBSD/amd64 will have no problem.
It'll be more happy that pkgsrc's patches are imported.

Comment 16

[Makoto Kato [:m_kato]]

Attachment: a patch for FreeBSD/amd64

Should we rename *x86_64_linux.cpp to *x86_64_unixish.cpp like x86?
Also, *amd64_openbsd.cpp is same code of *x86_64_linux.cpp.  So if I have to rename x86_64_linux.cpp to x86_64-unixish.cpp, I should remove *amd64_openbsd.cpp and modify Makefile.in for OpenBSD too.

Comment 17

[okazaki]

I agree with it.

Comment 18

[Makoto Kato [:m_kato]]

check in
http://hg.mozilla.org/mozilla-central/rev/08897e5342b4