Closed Bug 434989 Opened 15 years ago Closed 15 years ago

patch for FreeBSD 8-current (and after 7.0)

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
Other
FreeBSD
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: okazaki, Assigned: m_kato)

Details

Attachments

(1 file, 9 obsolete files)

a patch for FreeBSD/amd64
791 bytes, patch
benjamin
: review+
benjamin
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8.1.14) Gecko/20080423 Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8.1.14) Gecko/20080423 Firefox/2.0.0.14

1. Since FreeBSD has no /usr/bin/objformat after 7.0-RELEASE,
   $MOZ_OBJFORMAT is selected with "aout".
2. support amd64.


Reproducible: Always
Attached patch patch for build (obsolete) — — Splinter Review 
Component: OS Integration → Build Config
QA Contact: os.integration → build.config

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch ver.2 (obsolete)
        — 
          — Splinter Review
      

    


  
fix patch for security/coreconf/FreeBSD.mk.

        Attachment #321923 -
        Attachment is obsolete: true

    
    

    
  
Okazaki-san, could you split bug into NSPR, NSS and mozilla?

Also, you should not attach diff of "configure" because some configure files are generated automatelly.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch-for NSS (obsolete)
        — 
          — Splinter Review
      

    


  
extract NSS patch from ver.2

        Attachment #322493 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for nspr (obsolete)
        — 
          — Splinter Review
      

    


  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for xpcom (obsolete)
        — 
          — Splinter Review
      

    


  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for mozilla (obsolete)
        — 
          — Splinter Review
      

    


  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for mozilla v2 (obsolete)
        — 
          — Splinter Review
      

    


  
fogot to delete diff for "configure"

        Attachment #324398 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for nspr v2 (obsolete)
        — 
          — Splinter Review
      

    


  
fogot to delete diff for "configure"

        Attachment #324396 -
        Attachment is obsolete: true

    
    

    
  
Okazaki-san, other code for freebsd/elf is checked in as bug 436806.  Could you test it? 

    
    

    
  
I can't test it since I can't get patched version from cvs,
but bug 436806's patch seems fine for me.


    
    

    
  
I patched by hand and tested bug 43806's patch,
FreeBSD/amd64 needs one more patch
 for  /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in.


    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for xpcom(amd64) (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #324397 -
        Attachment is obsolete: true

    
    

    
  
(In reply to comment #12)
> I patched by hand and tested bug 43806's patch,
> FreeBSD/amd64 needs one more patch
>  for  /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in.
> 

Okazaki-san,
Although this patch is for *BSD, does it works on other BSD such as NetBSD/amd64 and Darwin/amd64??


Assignee: nobody → m_kato

    
    

    
  
I think they will work, but I didn't check it.
NetBSD's pksrc patch(pkgsrc/www/firefox3/patches/patch-ac) is 
also use xptcinvoke_x86_64_linux.cpp and xptcstubs_x86_64_linux.cpp 
for x86_64, so NetBSD/amd64 will have no problem.
It'll be more happy that pkgsrc's patches are imported.



    
    

    
  


  
Should we rename *x86_64_linux.cpp to *x86_64_unixish.cpp like x86?
Also, *amd64_openbsd.cpp is same code of *x86_64_linux.cpp.  So if I have to rename x86_64_linux.cpp to x86_64-unixish.cpp, I should remove *amd64_openbsd.cpp and modify Makefile.in for OpenBSD too.

        Attachment #324395 -
        Attachment is obsolete: true

        Attachment #324400 -
        Attachment is obsolete: true

        Attachment #324402 -
        Attachment is obsolete: true

        Attachment #331551 -
        Attachment is obsolete: true

    
  
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  
I agree with it.


    
  

        Attachment #332910 -
        Flags: superreview?(benjamin)

        Attachment #332910 -
        Flags: review?(benjamin)

    
  

        Attachment #332910 -
        Flags: superreview?(benjamin)

        Attachment #332910 -
        Flags: review?(benjamin)

        Attachment #332910 -
        Flags: review+

    
  

        Attachment #332910 -
        Flags: superreview?(benjamin)

    
  

        Attachment #332910 -
        Flags: superreview?(benjamin) → superreview+

    
    

    
  
check in
http://hg.mozilla.org/mozilla-central/rev/08897e5342b4
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.