435100 - Automatically-Connecting Weave triggers a "Master Password" dialog that must be dismissed before browser window will appear

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce:
 1. Set up Weave to automatically connect when you start Firefox:
   a) Click weave icon in status bar, and choose 'Sign Out'
   b) Click weave icon in status bar, and choose 'Sign In'
   c) Enter your Weave login info when prompted, and ensure that both the 'Save password' and 'Automatically connect' boxes are checked.

 2. Set up a master Firefox password (Preferences, Security, 'Use a Master Password'

 3. Close Firefox, and then start it up again.

EXPECTED RESULTS:
  Firefox window appears, with "Master Password" dialog popping up over it, for initial weave connection.  Or something like that.

ACTUAL RESULTS:
  Just the Master Password Dialog appears.  The Browser window only appears after I dismiss the dialog.



Here's another example that has slightly weirder behavior:
1. Set up auto-connecting weave & a master password, as detailed above

2. Open multiple Firefox windows with content in each one.

3. Use File|Quit to exit, and choose to save your tabs & windows if prompted.

4. Start Firefox again.

ACTUAL RESULTS:
  All of your windows *except for one* are restored.  In place of the one missing window, there's a "Master Password" dialog.  The missing window will only appear after you dismiss that dialog.

Maybe this is intended behavior, but it's kind of annoying.  IMHO, it'd be a lot more intuitive to have the browser window(s) start up, and THEN have the master password dialog appear. (as described in the initial example's "EXPECTED RESULTS")

Comment 1

[Daniel Holbert [:dholbert]]

FWIW, when I try the initial steps from Comment 0, Weave now triggers *two* master password dialogs -- one before the Firefox window is visible, and then another one after the window is visible.  (I'm clicking 'cancel' on both)

I'm seeing this with Weave 0.1.30 / Firefox 3rc2 / Ubuntu Linux 8.04

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to comment #1)
> FWIW, when I try the initial steps from Comment 0, Weave now triggers *two*
> master password dialogs

If I cancel the first dialog, but then enter my password in the second one, it doesn't seem to have any effect -- Weave remains signed out, with "Error" showing in the status bar.  So, it's unclear what the purpose of the second dialog is.

Also, the following is printed to STDOUT when I cancel each Master Password dialog (i.e. if I cancel both master-password dialogs, I get two copies of the message):

2008-06-09 18:26:03     Async.Generator ERROR   Exception: [Exception... "'User canceled Master Password entry' when calling method: [nsILoginManagerStorage::findLogins]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: file:///home/dholbert/programs/firefox-3.0rc1-build1/components/nsLoginManager.js :: anonymous :: line 465"  data: no]

Comment 3

[Dan Mills [:thunder]]

Punting to 0.3.

Comment 4

[Dan Mills [:thunder]]

These bugs need to be triaged, removing 0.3 milestone setting.

Comment 5

[Tianon Gravi]

I do like this, but having a few of the windows show up is irritating.  They should ALL wait until the Master Password window has been dismissed (by either entering the master password or by pressing Cancel, which would kill your on-firefox-open password sync).

Just as a side-note, Google's Sync extension also did this.

Comment 6

[Dan Mills [:thunder]]

As of 0.2.93 (or .94 maybe), we've switched to using a later event to begin Weave initialization at startup.  We now begin after all windows have been restored.

Marking as fixed.