435241 - Remove NS_NewPipe usage from mailnews

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Prasad Sunkari [:prasad]]

Mailnews should not use NS_NewPipe, instead it should directly create the pipes using nsIPipe interface.  This is required for mailnews to link to frozen linkage.

Comment 1

[Prasad Sunkari [:prasad]]

Attachment: Removes NS_NewPipe from mailnews/base/util

Patch for mailnews/base/util.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 322151 [details] [diff] [review]
Removes NS_NewPipe from mailnews/base/util

r+sr=dmose if you get replace the temporaries since each one causes an extra AddRef/Release pair.

Comment 3

[Prasad Sunkari [:prasad]]

Attachment: [checked in] Removes NS_NewPipe from mailnews/base/util - v2

uses raw pointers to get the streams.
fix for mailnews/base/util.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 322156 [details] [diff] [review]
[checked in] Removes NS_NewPipe from mailnews/base/util - v2

r+sr=dmose

Comment 5

[Prasad Sunkari [:prasad]]

Attachment: [checked in] Removes NS_NewPipe from mailnews/addrbook

Fixes mailnews/addrbook.
Again a tiny patch :)

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 322163 [details] [diff] [review]
[checked in] Removes NS_NewPipe from mailnews/addrbook

r+sr=dmose

Comment 7

[Prasad Sunkari [:prasad]]

Attachment: [checked in] Removes NS_NewPipe from mailnews/mime

Removes NS_NewPipe from mailnews/mime.

1.I removed the macros for segment size and buffer length because they are not used anywhere else and the buffer length has to anyway change to segment count when using nsIPipe directly.

2.In this case chaning nsI(Input|Output)Stream to nsIAsync(Input|Output)Stream directly in the class declaration seems to be of extremely low risk.  Actually, the mInputStream does not even seem to be required because it is a private variable and is used only in one function in the implementation of this class.

Comment 8

[Prasad Sunkari [:prasad]]

In comment (2) above, the extremely low risk can be read as 'no risk'. About mInputStream, i meant that it can be moved directly to the implementation of nsStreamConverter::Init instead of having a class variable.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 322156 [details] [diff] [review]
[checked in] Removes NS_NewPipe from mailnews/base/util - v2

Checking in mailnews/base/util/nsMsgProtocol.cpp;
/cvsroot/mozilla/mailnews/base/util/nsMsgProtocol.cpp,v  <--  nsMsgProtocol.cpp
new revision: 1.154; previous revision: 1.153
done

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 322163 [details] [diff] [review]
[checked in] Removes NS_NewPipe from mailnews/addrbook

Checking in mailnews/addrbook/src/nsAddbookProtocolHandler.cpp;
/cvsroot/mozilla/mailnews/addrbook/src/nsAddbookProtocolHandler.cpp,v  <--  nsAddbookProtocolHandler.cpp
new revision: 1.60; previous revision: 1.59
done

Comment 11

[Prasad Sunkari [:prasad]]

Attachment: [checked in] Removes NS_NewPipe from mailnews/imap

Patch for mailnews/imap:

Moved nsI(Output|Input)Stream to nsIAsync(Input|Output)Stream in the class declaration.  All the places where these are used in the implementations should be fine with this change.

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 322233 [details] [diff] [review]
[checked in] Removes NS_NewPipe from mailnews/mime

r+sr=dmose

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 322264 [details] [diff] [review]
[checked in] Removes NS_NewPipe from mailnews/imap

r+sr=dmose

Comment 14

[Prasad Sunkari [:prasad]]

Attachment: [checked in] Patch for mailnews/news

Comment 15

[Prasad Sunkari [:prasad]]

Attachment: [checked in] Patch for mailnews/compose

Comment 16

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 322276 [details] [diff] [review]
[checked in] Patch for mailnews/news

r+sr=dmose

Comment 17

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 322277 [details] [diff] [review]
[checked in] Patch for mailnews/compose

r+sr=dmose

Comment 18

[Mark Banner (:standard8)]

Comment on attachment 322264 [details] [diff] [review]
[checked in] Removes NS_NewPipe from mailnews/imap

Checking in mailnews/mime/src/nsStreamConverter.cpp;
/cvsroot/mozilla/mailnews/mime/src/nsStreamConverter.cpp,v  <--  nsStreamConverter.cpp
new revision: 1.137; previous revision: 1.136
done
Checking in mailnews/mime/src/nsStreamConverter.h;
/cvsroot/mozilla/mailnews/mime/src/nsStreamConverter.h,v  <--  nsStreamConverter.h
new revision: 1.28; previous revision: 1.27
done
Checking in mailnews/imap/src/nsImapProtocol.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v  <--  nsImapProtocol.cpp
new revision: 1.683; previous revision: 1.682
done
Checking in mailnews/imap/src/nsImapProtocol.h;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.h,v  <--  nsImapProtocol.h
new revision: 1.212; previous revision: 1.211
done

Comment 19

[Mark Banner (:standard8)]

Comment on attachment 322276 [details] [diff] [review]
[checked in] Patch for mailnews/news

Checking in mailnews/news/src/nsNNTPProtocol.cpp;
/cvsroot/mozilla/mailnews/news/src/nsNNTPProtocol.cpp,v  <--  nsNNTPProtocol.cpp
new revision: 1.400; previous revision: 1.399
done
Checking in mailnews/news/src/nsNNTPProtocol.h;
/cvsroot/mozilla/mailnews/news/src/nsNNTPProtocol.h,v  <--  nsNNTPProtocol.h
new revision: 1.107; previous revision: 1.106
done

Comment 20

[Mark Banner (:standard8)]

Comment on attachment 322277 [details] [diff] [review]
[checked in] Patch for mailnews/compose

Checking in mailnews/compose/src/nsSmtpService.cpp;
/cvsroot/mozilla/mailnews/compose/src/nsSmtpService.cpp,v  <--  nsSmtpService.cpp
new revision: 1.152; previous revision: 1.151
done

Comment 21

[Prasad Sunkari [:prasad]]

All NS_NewPipe instances from mailnews are now gone :)
resolution => Fixed