435313 - Printing on linux should set SIMPLIFY_OPERATORS | DISABLE_SNAPPING

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

On Win32, we set SIMPLIFY_OPERATORS | DISABLE_SNAPPING flags on the gfxContext to convert (e.g.) ADD operations to OVER operations to avoid huge fallbacks in print output.  We should do the same for Linux, for PS/PDF output.

Comment 1

[Carl Worth]

Attachment: First attempt at patch (untested)

Does this look about right?

I haven't even build tested this yet, so it's probably not correct yet.

-Carl

Comment 2

[Carl Worth]

Attachment: Second patch (still unted, but at least modifies the .h files as well this time)

Here's another attempt.

Closer certainly, but still might not be there yet.

-Carl

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: use the existant definition

Carl pointed me to this bug.  This is the patch I'm testing.

Comment 4

[Devin Cofer]

Any news?

Comment 5

[Reed Loden [:reed]]

http://hg.mozilla.org/mozilla-central/rev/e0cb183375dd

Comment 6

[Ilja Sekler]

Any chance to get this into mozilla-1.9.2? The patch applies cleanly and doesn't cause problems as far as I can tell from running a patched Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b6pre) Gecko/20091221 Firefox/3.6b6pre (SourceStamp=88d9224dda3c+).

In particular, the patch prevents printing from using image fallbacks for border corners in testcase <https://bugzilla.mozilla.org/attachment.cgi?id=335346> (please ignore the obsolete text in the testcase).

Comment 7

[Reed Loden [:reed]]

Comment on attachment 322206 [details] [diff] [review]
use the existant definition

The boat has sailed for 1.9.2, but maybe 1.9.2.1.

Comment 8

[Johnathan Nightingale [:johnath]]

Comment on attachment 322206 [details] [diff] [review]
use the existant definition

Another ship out of the harbour, but it's + for 1.9.2.3

Comment 9

[Johnathan Nightingale [:johnath]]

Comment on attachment 322206 [details] [diff] [review]
use the existant definition

Sorry for the bugspam - this should have been moved to a ?, not a +. I think we should take this in 1.9.2.3, but the tree isn't yet open for those checkins, so we'll circle back around and + once it is.

Comment 10

[Ilja Sekler]

(In reply to comment #9)
> [...] I think we should take this in 1.9.2.3 [...].

My apologies for bugspam, but this "sleeping beauty" patch is about to miss 1.9.2.5 or even has already missed it. Please, '+' it.

Comment 11

[LegNeato]

Comment on attachment 322206 [details] [diff] [review]
use the existant definition

a=LegNeato for 1.9.2.9.

Comment 12

[Ilja Sekler]

Has the train left the station even for 1.9.2.9? Please, please, push this patch into the release branch for 1.9.2.9 if possible. It is around there for over 8 months resp. mozilla-1.9.2.

My apologies for noise!

Comment 13

[Jeff Muizelaar [:jrmuizel]]

I believe the train has already left. Sorry.

Comment 14

[LegNeato]

Comment on attachment 322206 [details] [diff] [review]
use the existant definition

Removing .9 approval as this missed landing before freeze.

Comment 15

[LegNeato]

Comment on attachment 322206 [details] [diff] [review]
use the existant definition

Approving for 1.9.2.11. If this one misses the release again (code freeze is on this coming Tuesday, 2010-09-28) we likely won't take it in the future.

Comment 16

[Ilja Sekler]

(In reply to comment #15)

> Approving for 1.9.2.11.

Thank you.

> If this one misses the release again (code freeze is on this coming Tuesday, 
> 2010-09-28) we likely won't take it in the future.

The "checkin-needed" keyword is already set, it is up to developers to give this story a happy end.

Anyone with write access to the repository, please push this patch to the mozilla-1.9.2 branch today - there is no tomorrow for this.

Comment 17

[Reed Loden [:reed]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2c72c179ce74