Closed Bug 435313 Opened 15 years ago Closed 13 years ago

Printing on linux should set SIMPLIFY_OPERATORS | DISABLE_SNAPPING

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- .11-fixed

People

(Reporter: vlad, Assigned: caillon)

Details

Attachments

(1 file, 2 obsolete files)

On Win32, we set SIMPLIFY_OPERATORS | DISABLE_SNAPPING flags on the gfxContext to convert (e.g.) ADD operations to OVER operations to avoid huge fallbacks in print output.  We should do the same for Linux, for PS/PDF output.
Flags: wanted1.9.0.x+
Does this look about right?

I haven't even build tested this yet, so it's probably not correct yet.

-Carl
Here's another attempt.

Closer certainly, but still might not be there yet.

-Carl
Attachment #322200 - Attachment is obsolete: true
Carl pointed me to this bug.  This is the patch I'm testing.
Attachment #322204 - Attachment is obsolete: true
Attachment #322206 - Flags: review?(vladimir)
Attachment #322206 - Flags: review?(vladimir) → review+
Any news?
Assignee: nobody → caillon
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/e0cb183375dd
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Any chance to get this into mozilla-1.9.2? The patch applies cleanly and doesn't cause problems as far as I can tell from running a patched Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b6pre) Gecko/20091221 Firefox/3.6b6pre (SourceStamp=88d9224dda3c+).

In particular, the patch prevents printing from using image fallbacks for border corners in testcase <https://bugzilla.mozilla.org/attachment.cgi?id=335346> (please ignore the obsolete text in the testcase).
Comment on attachment 322206 [details] [diff] [review]
use the existant definition

The boat has sailed for 1.9.2, but maybe 1.9.2.1.
Attachment #322206 - Flags: approval1.9.2.1?
Attachment #322206 - Flags: approval1.9.2.2? → approval1.9.2.3+
Comment on attachment 322206 [details] [diff] [review]
use the existant definition

Another ship out of the harbour, but it's + for 1.9.2.3
Comment on attachment 322206 [details] [diff] [review]
use the existant definition

Sorry for the bugspam - this should have been moved to a ?, not a +. I think we should take this in 1.9.2.3, but the tree isn't yet open for those checkins, so we'll circle back around and + once it is.
Attachment #322206 - Flags: approval1.9.2.3+ → approval1.9.2.3?
(In reply to comment #9)
> [...] I think we should take this in 1.9.2.3 [...].

My apologies for bugspam, but this "sleeping beauty" patch is about to miss 1.9.2.5 or even has already missed it. Please, '+' it.
Attachment #322206 - Flags: approval1.9.2.4? → approval1.9.2.8?
Comment on attachment 322206 [details] [diff] [review]
use the existant definition

a=LegNeato for 1.9.2.9.
Attachment #322206 - Flags: approval1.9.2.9? → approval1.9.2.9+
Has the train left the station even for 1.9.2.9? Please, please, push this patch into the release branch for 1.9.2.9 if possible. It is around there for over 8 months resp. mozilla-1.9.2.

My apologies for noise!
I believe the train has already left. Sorry.
Attachment #322206 - Flags: approval1.9.2.10?
Comment on attachment 322206 [details] [diff] [review]
use the existant definition

Removing .9 approval as this missed landing before freeze.
Attachment #322206 - Flags: approval1.9.2.9+ → approval1.9.2.9-
Comment on attachment 322206 [details] [diff] [review]
use the existant definition

Approving for 1.9.2.11. If this one misses the release again (code freeze is on this coming Tuesday, 2010-09-28) we likely won't take it in the future.
Attachment #322206 - Flags: approval1.9.2.11? → approval1.9.2.11+
(In reply to comment #15)

> Approving for 1.9.2.11.

Thank you.

> If this one misses the release again (code freeze is on this coming Tuesday, 
> 2010-09-28) we likely won't take it in the future.

The "checkin-needed" keyword is already set, it is up to developers to give this story a happy end.

Anyone with write access to the repository, please push this patch to the mozilla-1.9.2 branch today - there is no tomorrow for this.
You need to log in before you can comment on or make changes to this bug.