Do XULRunner 1.9RC2 release spin

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
10 years ago
5 years ago

People

(Reporter: Benjamin Smedberg, Assigned: mfinkle)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 3 obsolete attachments)

(Reporter)

Description

10 years ago
We should do a XULRunner 1.9RC1 spin using the FF3RC1 source code, by following the instructions outlined at https://bugzilla.mozilla.org/show_bug.cgi?id=415180#c47

mfinkle, can you do this?
It has been decided that there will be an RC2 of Firefox 3 so I suggest that we instead do a spin of XULRunner based on the RC2 code which apparently will be code complete in the next day or so.
Summary: Do XULRunner 1.9RC1 release spin → Do XULRunner 1.9RC2 release spin
(Assignee)

Comment 2

10 years ago
Created attachment 322923 [details] [diff] [review]
bootstrap.cfg for xulrunner based in firefox rc2

bootstra.cfg we can use to generate a xulrunner build based on the firefox 3rc2 codebase.

Ben, I wasn't sure if we needed appVersion, oldAppVersion, and oldBuild. I removed prettyAUSVersion as it wasn't in the fx-moz19-bootstrap.cfg file (whic I was using as an example)
Attachment #322923 - Flags: review?(bhearsum)
(Assignee)

Comment 3

10 years ago
Created attachment 322930 [details] [diff] [review]
bootstrap.cfg for staging to test this first

We can try this on staging first. I kept prettyAUSVersion in case the string was used somewhere and changed the "3.0" stuff to "1.9" since xulrunner is the platform, not firefox.
Attachment #322923 - Attachment is obsolete: true
Attachment #322930 - Flags: review?(bhearsum)
Attachment #322923 - Flags: review?(bhearsum)
Comment on attachment 322930 [details] [diff] [review]
bootstrap.cfg for staging to test this first

>Index: tools/release/configs/xr-moz19-staging-bootstrap.cfg
>===================================================================
> # oldVersion and oldRc refer to the previous release
>-oldVersion      = 3.0b2
>+oldVersion      = 1.9b4

Is 1.9b4 the last time there was a Xulrunner release? It shouldn't matter, since AFAICT this is only used for updates, l10n, and automatic staging.

This is fine to land, afaict. For some reason I thought that we popped nightlies/dep builds out with Buildbot, which isn't the case. This is even easier than I originally thought, hooray! I'd still like to test this on staging first because of the version change, but I expect no problems.

(ref: https://bugzilla.mozilla.org/show_bug.cgi?id=415180#c47)

mfinkle: you can go ahead and push the buttons here when you land: http://staging-1.9-master.build.mozilla.org:8810/waterfall

Builds should show up here: http://fx-linux-1.9-slave1.build.mozilla.org/pub/mozilla.org/xulrunner/nightly/
Attachment #322930 - Flags: review?(bhearsum) → review+
Forgot to mention:
We should wait until the Fx 3.0rc2 build is idle/done before doing it for realz.
(Assignee)

Comment 6

10 years ago
Created attachment 322942 [details] [diff] [review]
bootstrap.cfg for production

Ok, this is the cfg for production
Attachment #322930 - Attachment is obsolete: true
Attachment #322942 - Flags: review?(bhearsum)
Comment on attachment 322942 [details] [diff] [review]
bootstrap.cfg for production

Looks fine. You should be able to land this whenever you want - don't kick the builds right away though.
Attachment #322942 - Flags: review?(bhearsum) → review+

Updated

10 years ago
Priority: -- → P2
Created attachment 322953 [details] [diff] [review]
[checked in] Enable symbol generation and upload for win32 release buidls
Attachment #322953 - Flags: review?(bhearsum)

Updated

10 years ago
Attachment #322953 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 9

10 years ago
Checking in tools/release/configs/xr-moz19-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/xr-moz19-bootstrap.cfg,v  <--  xr-moz19-bootstrap.cfg
new revision: 1.5; previous revision: 1.4
done

And:

cvs tag -F RELEASE_AUTOMATION_M9_1 tools/release/configs/xr-moz19-bootstrap.cfg
T tools/release/configs/xr-moz19-bootstrap.cfg

Comment on attachment 322953 [details] [diff] [review]
[checked in] Enable symbol generation and upload for win32 release buidls

Checking in xulrunner/win32/tinder-config.pl;
/cvsroot/mozilla/tools/tinderbox-configs/xulrunner/win32/tinder-config.pl,v  <--  tinder-config.pl
new revision: 1.11.2.4; previous revision: 1.11.2.3
done

Also carried over r=ted in bug 391718 to add source server support.
Attachment #322953 - Attachment description: Enable symbol generation and upload for win32 release buidls → [checked in] Enable symbol generation and upload for win32 release buidls
Probably doesn't matter but should prettyAUSString be XULRunner 1.9?
prettyAusVersion actually went away in bug 420947 so it can be removed from the configs. There's a bunch of stuff in the bootstrap configs that these XULrunner builds never use, as we're only doing the equivalent on an en-US build.
Created attachment 323046 [details] [diff] [review]
[checked in] Enable building SDK and put files in the right places

Two parts to this guy
* enable building the SDK like we do with nightly builds (all platforms)
* make the release builds go into the right place (mac and windows). We got a xulrunner/nightly/latest-xulrunner1.9rc2/ directory from the run yesterday, now removed.
Attachment #323046 - Flags: review?(bhearsum)

Updated

10 years ago
Attachment #323046 - Flags: review?(bhearsum) → review+
Created attachment 323557 [details] [diff] [review]
bump the buildid in the production config

apply this patch on attachment 322942 [details] [diff] [review]
Attachment #323557 - Flags: review?(bhearsum)

Updated

10 years ago
Attachment #323557 - Flags: review?(bhearsum) → review+
Comment on attachment 323046 [details] [diff] [review]
[checked in] Enable building SDK and put files in the right places

Sorry, this one fell in the yawning abyss.

mozilla/tools/tinderbox-configs/xulrunner/linux/tinder-config.pl 	1.8.2.6
mozilla/tools/tinderbox-configs/xulrunner/macosx/tinder-config.pl 	1.6.2.4
mozilla/tools/tinderbox-configs/xulrunner/win32/tinder-config.pl 	1.11.2.5
Attachment #323046 - Attachment description: Enable building SDK and put files in the right places → [checked in] Enable building SDK and put files in the right places
The RC2 builds are available at http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/1.9rc2-candidates/build2/ is there anything else that needs to be done or should we close this bug?
(Reporter)

Comment 17

10 years ago
Well, after we've gotten feedback that they're ok (and that we're not doing a FF3RC3), we should copy them to xulrunner/releases/1.9.
Someone discovered that the windows release is missing msvcm80.dll, msvcp80.dll, msvcr80.dll, Microsoft.VC80.CRT.manifest from the archive (both runtime and SDK)
The nightly versions _do_ have the files
Do we not build XULRunner --enable-jemalloc? We probably should.
WIN32_REDIST is set to /d/msvs8/VC/redist/x86/Microsoft.VC80.CRT on the XULRunner nightly tinderbox, but not on the machine used to create the XULRunner builds. You can set it in the tinder-config.pl for win32 if you decide against jemalloc.
Created attachment 324446 [details] [diff] [review]
incudes the update for RC3 and enables jemalloc 

fixes the jemalloc problem and bumps everything to rc3
Attachment #324446 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #324446 - Flags: review? → review?(nrthomas)
Created attachment 324448 [details] [diff] [review]
same as previous with prettyAusVersion removed
Attachment #324446 - Attachment is obsolete: true
Attachment #324448 - Flags: review?(nrthomas)
Attachment #324446 - Flags: review?(nrthomas)
Comment on attachment 324448 [details] [diff] [review]
same as previous with prettyAusVersion removed

>Index: tools/tinderbox-configs/xulrunner/win32/mozconfig
>===================================================================
>RCS file: /cvsroot/mozilla/tools/tinderbox-configs/xulrunner/win32/mozconfig,v
>retrieving revision 1.2
>diff -u -8 -p -r1.2 mozconfig
...
>+ac_add_options --enable-jemalloc

r+. The change above will affect nightlies, so also land this on the release branch before starting those builds off.
Attachment #324448 - Flags: review?(nrthomas) → review+
Created attachment 324453 [details] [diff] [review]
patch for release branch

enables jemalloc on release branch
Attachment #324453 - Flags: review?(nrthomas)
Attachment #324453 - Flags: review?(nrthomas) → review+
landed attachment 324448 [details] [diff] [review], tagged the .cfg file for release automation, and landed attachment 324453 [details] [diff] [review] for release branch
(Assignee)

Updated

10 years ago
Blocks: 439983
this is done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.