435726 - Cannot view source code for page under phishing protection

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Met - Martin Hassman]

Steps to reproduce:

1) Load page http://www.mozilla.com/firefox/its-an-attack.html
2) Click Ignore link so you can see "It’s an Attack!" page.
3) Now press CTRL+U to see its HTML source code

Results:
HTML souce code is inaccessible. In the source code window is Antiphishing warning again and you cannot pass through it.

Comment 1

[Adam Hauner]

Confirming with 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008052506 Minefield/3.0pre

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This isn't quite the same bug as bug 397937, given step 2), but it seems likely that any solution to it would depend on the a fix for bug 397937.

Comment 4

[Thomas]

I agree, bug 397937 is not duplicate of this bug. In fact, bug 397937 is not actually a bug. But this one definitely is. If I agree to view malicious page as is, why can't I view its source?

Comment 6

[Samuel Sidler (old account; do not CC)]

This isn't really wanted1.9.0.x, though I agree it sucks. Let's try and get it in 1.9.1.

Comment 8

[tony2]

This is really annoying as it ends up protecting the phishers source code, that makes it harder to track down and warn the ISP hosting the criminal's drop box.  I could turn the protection off but that means I can't tell whether a phishing page has already been reported.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking, but would take a patch ...

Comment 10

[Daniel Veditz [:dveditz]]

tweaking summary to catch dupes better.

You can get around this bug with the web developer toolbar's "View Source" or by manually prepending "view-source:" to the blocked URI, eg:
  view-source:http://www.mozilla.com/firefox/its-a-trap.html

Either way will get you the malware block but since it's in a normal tab/window you'll have a working "Ignore Warning" link. Since none of the buttons work on a malware block in the view-source popup I'm guessing it's simply not got the event-handling code for them (it's not a normal browser popup window, note how the menu is different and there's no location bar).

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Not worth focusing on this for Firefox 3.6, cc'ing ddahl who's starting to transition into owning these issues.

Comment 15

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This was fixed with bug 397937.
http://hg.mozilla.org/mozilla-central/rev/454c8ec86b1e

Comment 17

[Faust]

Has Blair McBride's patch been included in a release yet? How would I find this information out?

Comment 18

[David Dahl :ddahl]

(In reply to comment #17)
> Has Blair McBride's patch been included in a release yet? How would I find this
> information out?

comment 15 has a link to the moz-central changese, so I assume this change is in the minefield nightly build

Comment 19

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #18)
> comment 15 has a link to the moz-central changese, so I assume this change is
> in the minefield nightly build

Yes, in nightlies, but not in 3.6.x.