Closed Bug 435795 Opened 15 years ago Closed 15 years ago

Can't open Edit Task dialog via Return key for first entry in task list

Categories

(Calendar :: Tasks, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

Details

Attachments

(1 file)

Attached patch fix index checkSplinter Review
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/2008052608 Calendar/0.9pre

Currently it's not possible to open the Edit Task dialog for the first entry in the task list by pressing the Return key. It works for the second and following entry.
Attachment #322568 - Flags: review?(Berend.Cornelius)
Comment on attachment 322568 [details] [diff] [review]
fix index check

patch is Ok and resolves an obvious bug. Looking at the code around your bugfix I wonder if this has been done really optimally beforehand: Whereas the deletion of tasks is based on the selected tasks the editing and toggling (on DOM_VK_SPACE) is done on the currentIndex which only involves one single task. 
Cotrarily that behaviour: If you select several tasks and invoke "edit Item" via context you will have edit event dialogs pop up for each selected task. 
But that can be handled in a later issue.
Attachment #322568 - Flags: review?(Berend.Cornelius) → review+
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
patch checked in on trunk and MOZILLA_1_8_BRANCH

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Target Milestone: --- → 0.9
checked in lightning build 2008052818 and sunbird 20080528 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.