435795 - Can't open Edit Task dialog via Return key for first entry in task list

Status: VERIFIED FIXED

(Calendar :: Tasks, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: fix index check

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/2008052608 Calendar/0.9pre

Currently it's not possible to open the Edit Task dialog for the first entry in the task list by pressing the Return key. It works for the second and following entry.

Comment 1

[Berend Cornelius]

Comment on attachment 322568 [details] [diff] [review]
fix index check

patch is Ok and resolves an obvious bug. Looking at the code around your bugfix I wonder if this has been done really optimally beforehand: Whereas the deletion of tasks is based on the selected tasks the editing and toggling (on DOM_VK_SPACE) is done on the currentIndex which only involves one single task. 
Cotrarily that behaviour: If you select several tasks and invoke "edit Item" via context you will have edit event dialogs pop up for each selected task. 
But that can be handled in a later issue.

Comment 2

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH

->FIXED

Comment 3

[Andreas Treumann]

checked in lightning build 2008052818 and sunbird 20080528 -> VERIFIED