436054 - Password Manager (for Fennec)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Description

[Christian Sejersen]

Comment 1

[Justin Dolske [:Dolske]]

What's needed beyond the existing password manager in Firefox? Better front-end UI?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Changes to the nsLoginManagerPrompt code, so we don't popup the dialog. Perhaps we could make a better, more generic approach.

Comment 3

[Justin Dolske [:Dolske]]

Automatically logging in w/o a dialog is bug 223636.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't think that's what I was thinking :)

nsLoginManagerPrompt looks for elements specific to Firefox UI in order to activate the notificationBox. We probably need a more generic way to expose the UI as Fennec might not be using the same kind of notificationBox, but we still want a UI to appear.

Comment 5

[Justin Dolske [:Dolske]]

Ah, so more along the lines of bug 422974 and bug 430959. :-)

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

bug 422974 for sure :)

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Justin - would it be possible to pass a "listener" to the login system? Then when nsILoginManagerPrompter could check for a listener and call a method. That method would be responsible for the UI and could return a const for the action required.

Comment 8

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

This is kind of a hacked up patch. I manually edited it to remove the bits that are from bug 436057 for the sake of clarity. I should learn MQ...

TODO:
* I guess Fennec doesn't have tabs yet, so getNotificationBox() doesn't need the code from the Firefox version?
* Not sure of the implication of stubbed out openURI/isTabContentWindow methods. Probably not an issue for now.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #8)
> * I guess Fennec doesn't have tabs yet, so getNotificationBox() doesn't need
> the code from the Firefox version?

Right

> * Not sure of the implication of stubbed out openURI/isTabContentWindow
> methods. Probably not an issue for now.

Shouldn't be a problem

This patch depends on bug 444504

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 328838 [details] [diff] [review]
Patch v.1

Remove the XXX tabs commented block. 

bug 444504 landed for the notification support.

Comment 11

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Comment 12

[Justin Dolske [:Dolske]]

Pushed changeset 6c8aee85d0ca.

Comment 13

[Aakash Desai [:aakashd]]

We have a host of litmus testcases for the password manager located in:

https://litmus.mozilla.org/show_test.cgi?id=7263
https://litmus.mozilla.org/show_test.cgi?id=7229
https://litmus.mozilla.org/show_test.cgi?id=7305
https://litmus.mozilla.org/show_test.cgi?id=7115

Also, verified FIXED using gmail on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090817 Fennec/1.0a3pre


Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090817
Fennec/1.0b3pre