Closed Bug 436054 Opened 12 years ago Closed 12 years ago

Password Manager (for Fennec)

Categories

(Firefox for Android Graveyard :: General, enhancement, P1)

enhancement

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0m7

People

(Reporter: christian.bugzilla, Assigned: Dolske)

References

Details

Attachments

(1 file, 1 obsolete file)

 
Target Milestone: Fennec M5 → Fennec M4
What's needed beyond the existing password manager in Firefox? Better front-end UI?
Changes to the nsLoginManagerPrompt code, so we don't popup the dialog. Perhaps we could make a better, more generic approach.
Automatically logging in w/o a dialog is bug 223636.
I don't think that's what I was thinking :)

nsLoginManagerPrompt looks for elements specific to Firefox UI in order to activate the notificationBox. We probably need a more generic way to expose the UI as Fennec might not be using the same kind of notificationBox, but we still want a UI to appear.
Ah, so more along the lines of bug 422974 and bug 430959. :-)
Flags: blocking-fennec1.0+
Priority: -- → P1
Assignee: nobody → dolske
Target Milestone: Fennec M4 → Fennec M5
Justin - would it be possible to pass a "listener" to the login system? Then when nsILoginManagerPrompter could check for a listener and call a method. That method would be responsible for the UI and could return a const for the action required.
Depends on: 422974
Summary: Password Manager → Password Manager (for Fennec)
Depends on: 436057
Attached patch Patch v.1 (obsolete) — Splinter Review
This is kind of a hacked up patch. I manually edited it to remove the bits that are from bug 436057 for the sake of clarity. I should learn MQ...

TODO:
* I guess Fennec doesn't have tabs yet, so getNotificationBox() doesn't need the code from the Firefox version?
* Not sure of the implication of stubbed out openURI/isTabContentWindow methods. Probably not an issue for now.
(In reply to comment #8)
> * I guess Fennec doesn't have tabs yet, so getNotificationBox() doesn't need
> the code from the Firefox version?

Right

> * Not sure of the implication of stubbed out openURI/isTabContentWindow
> methods. Probably not an issue for now.

Shouldn't be a problem

This patch depends on bug 444504
No longer depends on: 436057
Comment on attachment 328838 [details] [diff] [review]
Patch v.1

Remove the XXX tabs commented block. 

bug 444504 landed for the notification support.
Target Milestone: Fennec M5 → Fennec M6
Target Milestone: Fennec M6 → Fennec A1
Attached patch Patch v.2Splinter Review
Attachment #328838 - Attachment is obsolete: true
Attachment #333324 - Flags: review?(gavin.sharp)
Attachment #333324 - Flags: review?(gavin.sharp) → review+
Pushed changeset 6c8aee85d0ca.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: Fennec A1 → Fennec M7
We have a host of litmus testcases for the password manager located in:

https://litmus.mozilla.org/show_test.cgi?id=7263
https://litmus.mozilla.org/show_test.cgi?id=7229
https://litmus.mozilla.org/show_test.cgi?id=7305
https://litmus.mozilla.org/show_test.cgi?id=7115

Also, verified FIXED using gmail on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090817 Fennec/1.0a3pre


Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090817
Fennec/1.0b3pre
Status: RESOLVED → VERIFIED
Flags: in-litmus+
OS: Linux (embedded) → All
Hardware: Other → All
You need to log in before you can comment on or make changes to this bug.