Last Comment Bug 436250 - Livemarks can't be disabled at runtime
: Livemarks can't be disabled at runtime
Status: RESOLVED WORKSFORME
:
Product: Firefox
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: 3.0 Branch
: All All
: -- normal with 4 votes (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-29 00:13 PDT by Mike Perry
Modified: 2010-05-06 12:09 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Mike Perry 2008-05-29 00:13:20 PDT
The livemarks service has no pref that can disable fetching of livemarks for a period of time. The pref browser.bookmarks.livemark_refresh_seconds in toolkit/components/places/src/nsLivemarkService.js is only checked in the constructor, and the closest you can get to disabling the service is to set it to a really large number of seconds, which only has effect once the browser is restarted.

This could be fixed with a separate pref, or perhaps by making _shutdown() a scriptable idl-published call and moving the addObserver for the bookmarks service from the LivemarkService constructor to startup(). I think the latter is probably the cleaner approach. Any problems with this approach?
Comment 1 Mike Perry 2008-05-30 13:32:00 PDT
Note: this issue also applies to livebookmarks under FF2, but a fix doesn't look like it would be nearly as clean.
Comment 2 Marco Bonardo [::mak] 2009-03-11 16:47:37 PDT
we have stopUpdateLivemarks and start API methods in livemarkService
Comment 3 John J. Barton 2009-06-30 21:27:01 PDT
See also bug 499568
Comment 4 Gervase Markham [:gerv] 2009-11-26 07:26:37 PST
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Note You need to log in before you can comment on or make changes to this bug.