Closed
Bug 436276
Opened 16 years ago
Closed 13 years ago
SVG SMIL: Add support for animating non-length SVG attributes
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: codedread, Unassigned)
References
Details
(Whiteboard: [parity-Opera][parity-webkit])
Attachments
(3 files)
Simple test to animate font-size CSS property, which does not yet work in the hg repository for SMIL at http://hg.mozilla.org/users/dholbert_mozilla.com/smil-patches/ See Bug 216462, Comment #58 for more details.
Comment 1•16 years ago
|
||
As far as I know the bug 216462 only implements animation of attributes which are lengths.
Reporter | ||
Comment 2•16 years ago
|
||
Thanks, that's good to know. My understanding from discussion with Daniel was that I could create bugs to cover missing functionality.
Comment 3•16 years ago
|
||
(In reply to comment #2) > My understanding from discussion with Daniel was > that I could create bugs to cover missing functionality. Yes, please do. (thanks for making this one)
Comment 4•16 years ago
|
||
Rather than overloading the "URL" field to point to the hg repository, I'm trying out a whiteboard syntax suggested by timeless, for dealing with hg branches: "[hgurl:c0]", which means "this is a bug on a specific hg repo, whose url is in comment 0". (alternately, we could just put the whole hg URL in the whiteboard, but hg urls are probably too long for that)
OS: Linux → All
Hardware: PC → All
Whiteboard: [hgurl:c0]
Updated•15 years ago
|
Whiteboard: [hgurl:c0]
Updated•15 years ago
|
Version: Other Branch → Trunk
Updated•15 years ago
|
Summary: SVG SMIL: Cannot animate font-size → SVG SMIL: Cannot animate css properties
Updated•15 years ago
|
Summary: SVG SMIL: Cannot animate css properties → SVG SMIL: Add support for animating non-length SVG attributes
Updated•15 years ago
|
Blocks: enablesmil
Comment 5•15 years ago
|
||
This test-case animates: y and rx for rect r for circle rx for ellipse points for polyline points for polygon
Comment 6•15 years ago
|
||
Since that last testcase works perfectly in Opera shouldn't this bug be labeled parity-opera? (It almost works in Safari 4 beta as well.)
Comment 7•15 years ago
|
||
(In reply to comment #6) > Since that last testcase works perfectly in Opera shouldn't this bug be labeled > parity-opera? (It almost works in Safari 4 beta as well.) I am not sure, do you suggest there is something in my test case that doesn't follow SVG standard? Yes, it works in Opera - just like the first test case. However it wasn't written to match Opera's SVG implementation. It's as simply as the fact that Opera just supports SVG really well.
Comment 8•15 years ago
|
||
Lars: Yes, it should -- thanks. Rafał: I think you misunderstood Lars' meaning from comment 6 -- he's simply saying that this bug is for a feature that Opera (and WebKit) already supports, and we should label it as such. (also -- thanks for the great testcase!)
Whiteboard: [parity-opera][parity-webkit]
Updated•15 years ago
|
Whiteboard: [parity-opera][parity-webkit] → [parity-Opera][parity-webkit]
Comment 10•15 years ago
|
||
Ouch, I didn't understand Lars. Thanks for explaining. I reported bug #491268 which is duplicate of this one as I didn't know x and y attributes of text are lists. I'll attach test-case for testing textx elements with single values in x/dx/y/dy.
Comment 11•15 years ago
|
||
Nothing special, just animating x/dx/y/dy attributes.
Updated•15 years ago
|
Flags: wanted-next+
Target Milestone: --- → mozilla1.9.3a1
Updated•15 years ago
|
Blocks: svg11tests
Updated•14 years ago
|
Updated•14 years ago
|
Comment 12•14 years ago
|
||
FWIW, all of this bug's testcases now work in mozilla-central nightly builds, except for the last two lines of the attachment 375599 [details] (for 'points'), which is being tracked in bug 522308.
Comment 13•14 years ago
|
||
What about supporting begin="click" or begin="mouseover" in animations? As far as I know, they don't work yet. At least the following example didn't work, while it works in Webkit-based browsers and in Opera. <circle id="circle" cx="240" cy="135" r="135" fill="black" pointer-events="all"> <set attributeName="r" attributeType="XML" to="240" begin="mouseover" dur="6s"/> </circle>
Comment 14•14 years ago
|
||
That's bug 485157, whose patches are currently undergoing review.
Comment 15•14 years ago
|
||
awesome - sorry my search didn't find it
Comment 16•13 years ago
|
||
Closing as there are no more types left.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.3a1 → mozilla9
Can we get rid of nsISVGValue/nsSVGValue and all related code now?
Comment 18•13 years ago
|
||
There's nsSVGStringProxyValue left which creates proxy objects for XUL I think for when we have attributes that won't parse e.g. x="?" which is then replaced. I imagine that could be rewritten though and nsISVGValue could go as part of that.
Is that actually still used? It looks to me like it wraps attributes which are themselves represented as nsISVGValues, and we've removed all those.
You need to log in
before you can comment on or make changes to this bug.
Description
•