436321 - Save Page As... context menu command has English access key

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Tsahi Asher]

The access key for the Save Page As... command in the page context menu is P instead of one of "שמור דף בשם" letters.

right-click on a web page where there is no form control or image or link or any, just a plain text area, to get this context menu.

Comment 1

[Tomer Cohen :tomer]

Attachment: patch

Comment 2

[Tsahi Asher]

DALED is a bad choice for this access key. it is already used by *two* other menu items in this menu - "bookmark this page" and "view page info". so you should also change the access key to one of those items.

Comment 3

[Tomer Cohen :tomer]

Attachment: patch v2

I've changed savePageCmd.accesskey2 of "Save page as" to BET, which is the same as "Save picture as", since both never appear together. 

bookmarkPageCmd2.accesskey has changed to SAMECH as Tsahi suggested in comment 2.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 325967 [details] [diff] [review]
patch v2

a=me, please land this with a check-in comment referencing this bug and my approval.

Please use the fixed1.9.0.1 and verified1.9.0.1 keywords to track landing and testing.

Comment 5

[Tsahi Asher]

it appears i wasn't sharp enough on this, and missed something else: BET is already used for Select All (בחר הכל), and also Reload and View Page Source both use MEM.

Comment 6

[Tomer Cohen :tomer]

(In reply to comment #5)
> it appears i wasn't sharp enough on this, and missed something else: BET is
> already used for Select All (בחר הכל), and also Reload and View Page
> Source both use MEM.
> 

I think we've just left us some more work for 3.0.2. :-) Can you please file a separated bug for this? Thanks.

Comment 7

[Tsahi Asher]

see bug 478442.

Comment 8

[Michael Kohler [:mkohler]]

This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.