436508 - Over-all QAC accessibility checkup

Status: RESOLVED FIXED

(Other Applications Graveyard :: QA Companion, defect)

Description

[Marco Zehe (:MarcoZ)]

Went through the QAC XUL files and found missing associations of labels to controls, some non-tabbable items and a few other items warranting XUL fix-up.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Patch

1. Add missing control attributes to labels.
2. Add aria-labelledby attribute to those textboxes which are logically labelled by the radio button that's preceeding each of them.
3. Convert xul:description elements into labels where appropriate.

Comment 2

[cmtalbert]

Comment on attachment 323074 [details] [diff] [review]
Patch

Marco, thanks for the patch!!!  This looks great.

Do you need me to check this in for you?

r=ctalbert

Comment 3

[Marco Zehe (:MarcoZ)]

(In reply to comment #2)
> Do you need me to check this in for you?

No, thanks! I'll land it shortly. Does this warrant a new build maybe?

Comment 4

[Zach Lipton [:zach]]

Thanks Marco this is awesome! I got a few suggestions from TimK last year, but please let us know if you come across any areas where Litmus can be improved to be more accessible, especially with your new testcases in place now.

Comment 5

[Marco Zehe (:MarcoZ)]

Checking in testing/extensions/community/chrome/content/setup.xul;
/cvsroot/mozilla/testing/extensions/community/chrome/content/setup.xul,v  <--  setup.xul
new revision: 1.9; previous revision: 1.8
done
Checking in testing/extensions/community/chrome/content/tabs/bugzilla.xul;
/cvsroot/mozilla/testing/extensions/community/chrome/content/tabs/bugzilla.xul,v  <--  bugzilla.xul
new revision: 1.10; previous revision: 1.9
done
Checking in testing/extensions/community/chrome/content/tabs/litmus.xul;
/cvsroot/mozilla/testing/extensions/community/chrome/content/tabs/litmus.xul,v  <--  litmus.xul
new revision: 1.15; previous revision: 1.14
done
Checking in testing/extensions/community/chrome/content/tabs/selecttests.xul;
/cvsroot/mozilla/testing/extensions/community/chrome/content/tabs/selecttests.xul,v  <--  selecttests.xul
new revision: 1.10; previous revision: 1.9
done