436668 - Localize name and description for the default theme

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Eduard Gamonal]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ca; rv:1.9pre) Gecko/2008053004 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ca; rv:1.9pre) Gecko/2008053004 Minefield/3.0pre

in «Themes» tab, the default theme is:

«Default   3.0pre
The default theme.»

Same for «Default plugin»

Are name and description to be localized for these elements? If they are hardcoded, maybe we should change it.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Dave Townsend [:mossop]]

We should be able to use the regular method for localising an add-ons data for this

Comment 2

[Jarret Falkner]

Attachment: French localization of default theme text

Trying to figure this out since it's marked 'good first bug'.

The patch will localize the default theme text using the standard rdf localization technique.  The 'Default Plugin' text comes from modules/plugin/default/unix/nullplugin.h -- any pointers about localizing header files?

Comment 3

[Dave Townsend [:mossop]]

Altering the install.rdf isn't I think the way to go here. Instead we should use the older method of localizing. This would involve adding localized preferences to firefox.js for the theme's name and description and having them pull their value from a properties file out of the locale. See http://developer.mozilla.org/en/Localizing_extension_descriptions#Localizing_before_Gecko_1.9 for more details.

I'm not sure what we can do with the default plugin for the time being, is it even enabled by default anymore?

Comment 4

[Stefan Plewako [:stef]]

(In reply to comment #3)
> I'm not sure what we can do with the default plugin for the time being, is it
> even enabled by default anymore?

Enabled but not registered for all content (*) types?
plugin.default_plugin_disabled is set to true in Firefox 3.5 but the about:plugins page lists it and in Tools → Addons → Plugins it is in enabled state.

Disabled or not, its description is visible in UI by default and it should be possible to localize it. (btw, bug 244477 is about the same)

Comment 5

[Dave Townsend [:mossop]]

Yeah lets keep this bug purely for the default theme, localizing the default plugin is a harder prospect.

Comment 6

[Stefan Plewako [:stef]]

Attachment: patch, v1

Comment 7

[Stefan Plewako [:stef]]

Attachment: the fix

I'm not sure who should review this and if the new lines are in the good enough place.

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 386950 [details] [diff] [review]
the fix

Looks good, thanks

Comment 9

[Dave Townsend [:mossop]]

Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/4efc65d6447d

Thanks for the patch.

Comment 10

[[e-mail]]

Bah, more toolkit prefs in firefox.js :-(

Comment 11

[Mark Banner (:standard8)]

(In reply to comment #10)
> Bah, more toolkit prefs in firefox.js :-(

Surely we could have put these in all.js at least until a toolkit.js file is created?

Comment 12

[Dave Townsend [:mossop]]

I've backed this out, we need to consider whether this should apply to other applications or not.

Comment 13

[Dave Townsend [:mossop]]

Comment on attachment 386950 [details] [diff] [review]
the fix

I think after further consideration this is wrong and the theme name and description should come from the Firefox locale (as currently happens).

Move the strings into browser/locales/en-US/chrome/browser/browser.properties and update the preference values and this will be right.

Comment 14

[Stefan Plewako [:stef]]

Attachment: updated patch

(In reply to comment #13)
> Move the strings into browser/locales/en-US/chrome/browser/browser.properties
> and update the preference values and this will be right.

Comment 15

[Dave Townsend [:mossop]]

Comment on attachment 394267 [details] [diff] [review]
updated patch

I'll land this when the tree is clear enough

Comment 16

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/432fb39d5655

Comment 17

[Dave Townsend [:mossop]]

Comment on attachment 394267 [details] [diff] [review]
updated patch

No risk patch, this just allows out localisers to customise the default theme name and description

Comment 18

[Benjamin Smedberg]

Comment on attachment 394267 [details] [diff] [review]
updated patch

a=me if this lands today

Comment 19

[Dave Townsend [:mossop]]

Landed on branch: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b0dfa9ad74ec