default color constants should be vars in EdColorProps.js

RESOLVED FIXED in seamonkey2.0a1

Status

SeaMonkey
Composer
--
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

({fixed-seamonkey1.1.10, fixed1.8.1.15})

Trunk
seamonkey2.0a1
fixed-seamonkey1.1.10, fixed1.8.1.15

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
If you set page colors in Composer (Format --> Page Colors and Background...), you get 5 warnings in the js console because the default color values are constants. The pref-composer.js part was fixed in bug 331024, but the EdColorProps.js part obviously remains.
(Assignee)

Comment 1

9 years ago
Created attachment 323209 [details] [diff] [review]
Use vars instead of constants
Attachment #323209 - Flags: superreview?(neil)
Attachment #323209 - Flags: review?(neil)

Comment 2

9 years ago
Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

As a bonus the default page colours preview properly :-)
Attachment #323209 - Flags: superreview?(neil)
Attachment #323209 - Flags: superreview+
Attachment #323209 - Flags: review?(neil)
Attachment #323209 - Flags: review+
Attachment #323209 - Flags: approval-seamonkey1.1.10?

Updated

9 years ago
Attachment #323209 - Flags: approval-seamonkey1.1.10? → approval-seamonkey1.1.10+
(Assignee)

Comment 3

9 years ago
Checked in to:

HEAD:
Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.41; previous revision: 1.40
done

MOZILLA_1_8_BRANCH:
Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.40.20.1; previous revision: 1.40
done

Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-seamonkey1.1.10
(Assignee)

Comment 4

9 years ago
Btw, filed bug 436726 in order to get a "fixed-seamonkey1.1.10" keyword
Target Milestone: --- → seamonkey2.0alpha
(Assignee)

Comment 5

9 years ago
(In reply to comment #4)
> Btw, filed bug 436726 in order to get a "fixed-seamonkey1.1.10" keyword
> 

Oh, there is already a keyword...
Keywords: fixed-seamonkey1.1.10
Whiteboard: fixed-seamonkey1.1.10
(Assignee)

Comment 6

9 years ago
I backed out the 1.8 branch part since I think it needs approval1.8.1.15.
Keywords: fixed-seamonkey1.1.10
(Assignee)

Comment 7

9 years ago
Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

Drivers, this is 0% risk and it fixes a small problem with code that is shared between seamonkey and thunderbird - the same js errors can be seen in thunderbird.
Attachment #323209 - Flags: approval1.8.1.15?
Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

Approved for 1.8.1.15, a=dveditz for release-drivers
Attachment #323209 - Flags: approval1.8.1.15? → approval1.8.1.15+
(Assignee)

Comment 9

9 years ago
Checked in to MOZILLA_1_8_BRANCH:

Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.40.20.3; previous revision: 1.40.20.2
done
Keywords: fixed-seamonkey1.1.10, fixed1.8.1.15
(Assignee)

Comment 10

9 years ago
reed, should this be landed in mozilla-central as well?
(Assignee)

Comment 11

9 years ago
oh, wait - wrong bug
(Assignee)

Updated

9 years ago
Blocks: 443837
Patch checked into mozilla-central in Bug 443837
You need to log in before you can comment on or make changes to this bug.