Closed Bug 436670 Opened 14 years ago Closed 14 years ago

default color constants should be vars in EdColorProps.js

Categories

(SeaMonkey :: Composer, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

(Keywords: fixed-seamonkey1.1.10, fixed1.8.1.15)

Attachments

(1 file)

If you set page colors in Composer (Format --> Page Colors and Background...), you get 5 warnings in the js console because the default color values are constants. The pref-composer.js part was fixed in bug 331024, but the EdColorProps.js part obviously remains.
Attachment #323209 - Flags: superreview?(neil)
Attachment #323209 - Flags: review?(neil)
Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

As a bonus the default page colours preview properly :-)
Attachment #323209 - Flags: superreview?(neil)
Attachment #323209 - Flags: superreview+
Attachment #323209 - Flags: review?(neil)
Attachment #323209 - Flags: review+
Attachment #323209 - Flags: approval-seamonkey1.1.10?
Attachment #323209 - Flags: approval-seamonkey1.1.10? → approval-seamonkey1.1.10+
Checked in to:

HEAD:
Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.41; previous revision: 1.40
done

MOZILLA_1_8_BRANCH:
Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.40.20.1; previous revision: 1.40
done

Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: fixed-seamonkey1.1.10
Btw, filed bug 436726 in order to get a "fixed-seamonkey1.1.10" keyword
Target Milestone: --- → seamonkey2.0alpha
(In reply to comment #4)
> Btw, filed bug 436726 in order to get a "fixed-seamonkey1.1.10" keyword
> 

Oh, there is already a keyword...
Whiteboard: fixed-seamonkey1.1.10
I backed out the 1.8 branch part since I think it needs approval1.8.1.15.
Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

Drivers, this is 0% risk and it fixes a small problem with code that is shared between seamonkey and thunderbird - the same js errors can be seen in thunderbird.
Attachment #323209 - Flags: approval1.8.1.15?
Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

Approved for 1.8.1.15, a=dveditz for release-drivers
Attachment #323209 - Flags: approval1.8.1.15? → approval1.8.1.15+
Checked in to MOZILLA_1_8_BRANCH:

Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.40.20.3; previous revision: 1.40.20.2
done
reed, should this be landed in mozilla-central as well?
oh, wait - wrong bug
Blocks: 443837
Patch checked into mozilla-central in Bug 443837
You need to log in before you can comment on or make changes to this bug.