436670 - default color constants should be vars in EdColorProps.js

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Stefan [:stefanh]]

If you set page colors in Composer (Format --> Page Colors and Background...), you get 5 warnings in the js console because the default color values are constants. The pref-composer.js part was fixed in bug 331024, but the EdColorProps.js part obviously remains.

Comment 1

[Stefan [:stefanh]]

Attachment: Use vars instead of constants

Comment 2

[[e-mail]]

Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

As a bonus the default page colours preview properly :-)

Comment 3

[Stefan [:stefanh]]

Checked in to:

HEAD:
Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.41; previous revision: 1.40
done

MOZILLA_1_8_BRANCH:
Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.40.20.1; previous revision: 1.40
done

Comment 4

[Stefan [:stefanh]]

Btw, filed bug 436726 in order to get a "fixed-seamonkey1.1.10" keyword

Comment 5

[Stefan [:stefanh]]

(In reply to comment #4)
> Btw, filed bug 436726 in order to get a "fixed-seamonkey1.1.10" keyword
> 

Oh, there is already a keyword...

Comment 6

[Stefan [:stefanh]]

I backed out the 1.8 branch part since I think it needs approval1.8.1.15.

Comment 7

[Stefan [:stefanh]]

Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

Drivers, this is 0% risk and it fixes a small problem with code that is shared between seamonkey and thunderbird - the same js errors can be seen in thunderbird.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 323209 [details] [diff] [review]
Use vars instead of constants

Approved for 1.8.1.15, a=dveditz for release-drivers

Comment 9

[Stefan [:stefanh]]

Checked in to MOZILLA_1_8_BRANCH:

Checking in editor/ui/dialogs/content/EdColorProps.js;
/cvsroot/mozilla/editor/ui/dialogs/content/EdColorProps.js,v  <--  EdColorProps.js
new revision: 1.40.20.3; previous revision: 1.40.20.2
done

Comment 10

[Stefan [:stefanh]]

reed, should this be landed in mozilla-central as well?

Comment 11

[Stefan [:stefanh]]

oh, wait - wrong bug

Comment 12

[Justin Wood (:Callek)]

Patch checked into mozilla-central in Bug 443837